Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Rewrote deliveryservices/{{ID}/safe to Go#4388

Merged
mitchell852 merged 10 commits into
apache:masterfrom
ocket8888:deliveryservices-id-safe-go
Feb 10, 2020
Merged

Rewrote deliveryservices/{{ID}/safe to Go#4388
mitchell852 merged 10 commits into
apache:masterfrom
ocket8888:deliveryservices-id-safe-go

Conversation

@ocket8888

@ocket8888 ocket8888 commented Feb 10, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR (Pull Request) do?

Rewrites /deliveryservices/{{ID}}/safe to Go with special handling for the new Delivery Service fields in API v1.3, 1.4 and 1.5. Also adds client methods, fixes some inaccurate documentation, adds integration tests, and updates the Python Client to support newer API versions for this endpoint.

Which Traffic Control components are affected by this PR?

  • Documentation
  • Traffic Control Client (Python)
  • Traffic Ops Client (Go)
  • Traffic Ops

What is the best way to verify this PR?

Run the associated client/api integration tests (TestPutDeliveryServiceSafe), build and read the documentation, make a PUT request to /api/1.5/deliveryservices/{{ID}}/safe - that doesn't need to succeed or even correspond to a real ID, just make sure the routing works.

The following criteria are ALL met by this PR

  • This PR includes tests
  • This PR includes documentation
  • An update to CHANGELOG.md is not necessary
  • This PR includes any and all required license headers
  • This PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

@ocket8888 ocket8888 added Traffic Ops related to Traffic Ops documentation related to documentation tests related to tests and/or testing infrastructure tech debt rework due to choosing easy/limited solution TC Client (python) related to the Python implementation of a TC client TO Client (Go) related to the Go implementation of a TC client labels Feb 10, 2020
@ocket8888 ocket8888 added this to the Go Rewrite milestone Feb 10, 2020
mhoppa
mhoppa reviewed Feb 10, 2020
View reviewed changes
Comment thread lib/go-tc/deliveryservices.go
mhoppa
mhoppa reviewed Feb 10, 2020
View reviewed changes
Comment thread docs/source/api/deliveryservices_id_safe.rst
mhoppa
mhoppa reviewed Feb 10, 2020
View reviewed changes
Comment thread traffic_ops/traffic_ops_golang/deliveryservice/safe.go
mhoppa
mhoppa reviewed Feb 10, 2020
View reviewed changes
Comment thread traffic_ops/traffic_ops_golang/routing/routes.go
mhoppa
mhoppa approved these changes Feb 10, 2020
View reviewed changes

@mhoppa mhoppa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manually tests well, API tests pass, unit tests pass, docs build and look good, code looks good :shipit:

@mitchell852
mitchell852 merged commit 626fb05 into apache:master Feb 10, 2020
@ocket8888
ocket8888 deleted the deliveryservices-id-safe-go branch February 10, 2020 22:05
@ocket8888 ocket8888 mentioned this pull request Feb 10, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@rob05c rob05c rob05c left review comments
@mhoppa mhoppa mhoppa approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation related to documentation TC Client (python) related to the Python implementation of a TC client tech debt rework due to choosing easy/limited solution tests related to tests and/or testing infrastructure TO Client (Go) related to the Go implementation of a TC client Traffic Ops related to Traffic Ops

Projects

None yet

Milestone

Go Rewrite

Development

Successfully merging this pull request may close these issues.

Rewrite /deliveryservices/{{id}}/safe to Go

5 participants

@ocket8888 @rob05c @mhoppa @mitchell852 @zrhoffman