Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Add TO Go put deliveryservices/id/safe#2455

Closed
rob05c wants to merge 1 commit into
apache:masterfrom
rob05c:to-go-ds-safe
Closed

Add TO Go put deliveryservices/id/safe#2455
rob05c wants to merge 1 commit into
apache:masterfrom
rob05c:to-go-ds-safe

Conversation

@rob05c

@rob05c rob05c commented Jun 22, 2018 •
edited by ocket8888
Loading

Copy link
Copy Markdown
Member

Rewrites /deliveryservices/{{id}}/safe to Go. Closes #3786

@rob05c rob05c added new feature A new feature, capability or behavior Traffic Ops API (golang) labels Jun 22, 2018
@rob05c rob05c mentioned this pull request Jun 22, 2018
Closed
@asfgit

asfgit commented Jun 22, 2018

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/1888/
Test PASSed.

@asfgit

asfgit commented Jun 22, 2018

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/1894/
Test PASSed.

@asfgit

asfgit commented Jul 1, 2018

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/1949/
Test PASSed.

@asfgit

asfgit commented Jul 1, 2018

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/1952/
Test PASSed.

@asfgit

asfgit commented Jul 9, 2018

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2053/
Test PASSed.

@ocket8888 ocket8888 mentioned this pull request Aug 6, 2019
Closed
1 task
@asfgit

asfgit commented Aug 15, 2019

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4148/
Test FAILed.

@mhoppa

mhoppa commented Oct 10, 2019

Copy link
Copy Markdown
Contributor

retest this please

@asf-ci

asf-ci commented Oct 11, 2019

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4450/

@mitchell852 mitchell852 added Traffic Ops related to Traffic Ops tech debt rework due to choosing easy/limited solution and removed new feature A new feature, capability or behavior labels Oct 24, 2019
@mitchell852 mitchell852 added this to the Go Rewrite milestone Oct 24, 2019
@ocket8888 ocket8888 self-assigned this Nov 12, 2019
@asf-ci

asf-ci commented Nov 13, 2019

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4779/

ocket8888
ocket8888 reviewed Nov 14, 2019
View reviewed changes

@ocket8888 ocket8888 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments

Comment thread lib/go-tc/deliveryservices.go Outdated
Comment thread traffic_ops/testing/api/v13/deliveryservicesafe_test.go Outdated
Comment thread traffic_ops/testing/api/v13/deliveryservicesafe_test.go Outdated
Comment thread traffic_ops/traffic_ops_golang/deliveryservice/safe.go Outdated
Comment thread traffic_ops/traffic_ops_golang/deliveryservice/safe.go Outdated
@ocket8888

ocket8888 commented Dec 18, 2019

Copy link
Copy Markdown
Contributor

Also can you rebase this?

@rob05c rob05c force-pushed the to-go-ds-safe branch 2 times, most recently from 83b2b2a to 1563cdb Compare December 30, 2019 18:18
@rob05c

rob05c commented Dec 30, 2019

Copy link
Copy Markdown
Member Author

Rebased, addressed all comments, ran tests again, API tests still pass, unit tests still pass.

ocket8888
ocket8888 reviewed Jan 3, 2020
View reviewed changes
Comment thread traffic_ops/testing/api/v14/deliveryservicesafe_test.go
rawlinp
rawlinp reviewed Jan 3, 2020
View reviewed changes
Comment thread traffic_ops/traffic_ops_golang/routing/routes.go
ocket8888
ocket8888 suggested changes Jan 3, 2020
View reviewed changes
Comment thread traffic_ops/traffic_ops_golang/deliveryservice/safe.go
@mhoppa

mhoppa commented Feb 4, 2020

Copy link
Copy Markdown
Contributor

updated feedback in rob05c#7 once merge I think this should be good to be merged

@ocket8888 ocket8888 mentioned this pull request Feb 10, 2020
Merged
7 tasks
@ocket8888

ocket8888 commented Feb 10, 2020

Copy link
Copy Markdown
Contributor

Superseded by #4388

@ocket8888 ocket8888 closed this Feb 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@ocket8888 ocket8888 ocket8888 requested changes
@rawlinp rawlinp rawlinp left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@ocket8888 ocket8888

Labels

abandoned tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops

Projects

None yet

Milestone

Go Rewrite

Development

Successfully merging this pull request may close these issues.

Rewrite /deliveryservices/{{id}}/safe to Go

8 participants

@rob05c @asfgit @mhoppa @asf-ci @ocket8888 @rawlinp @mitchell852 @zrhoffman