This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix API tests for header rewrite#4355
Merged
Merged
Conversation
Contributor
Author
|
@rob05c unsure if that was the best way to fix it but API tests are passing now let me know if you think it should be handled in other ways |
mitchell852
added
Traffic Ops
Contributor
Author
|
Thanks @rob05c for the offline help for coming up with the better solution :) and FWIW they were not broken it was an intermittent bug dependent on what DS was received for the test |
rawlinp
approved these changes
Jan 30, 2020
rawlinp
left a comment
rawlinp
left a comment
Contributor
There was a problem hiding this comment.
Ran API tests on master; they failed. Ran API tests on this PR; they passed.
rawlinp
pushed a commit
to rawlinp/trafficcontrol
that referenced
this pull request
Jan 30, 2020
* Fix API tests for header rewrite * Better approach :) (cherry picked from commit 24b1e84)
rawlinp
added a commit
that referenced
this pull request
Jan 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run API tests
If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Additional Information