Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

TP: fixes bug with delivery service requests when deleting a ds#4207

Merged
rawlinp merged 1 commit into
apache:masterfrom
mitchell852:issue-4192-delete-ds-request
Dec 16, 2019
Merged

TP: fixes bug with delivery service requests when deleting a ds#4207
rawlinp merged 1 commit into
apache:masterfrom
mitchell852:issue-4192-delete-ds-request

Conversation

@mitchell852

Copy link
Copy Markdown
Member

What does this PR (Pull Request) do?

The bug was never documented (obviously) so no documentation to fix.
DSRs are not under test.
No change log entry required.

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

  • Enable delivery service requests (dsRequests.enabled=true) in traffic_portal_properties.json and set overrideRole=admin
  • Launch TP
  • Login as an admin
  • delete a delivery service and select "fulfill immediately"

You will be directed back to the delivery services page and your delivery service will be gone. You can also verify that a delivery service request was created and closed/completed under https://tp.domain.com/#!/delivery-service-requests

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@mitchell852 mitchell852 added bug something isn't working as intended Traffic Portal v1 related to Traffic Portal version 1 labels Dec 12, 2019
@asf-ci

asf-ci commented Dec 12, 2019

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4926/

@rawlinp rawlinp self-assigned this Dec 16, 2019
@rawlinp
rawlinp merged commit 954b52f into apache:master Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug something isn't working as intended Traffic Portal v1 related to Traffic Portal version 1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deleting a DS via a DS request/fulfill immediately does not remove DS from the DS table

3 participants