Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Add deprecation notices to stats_summary/create#4186

Merged
ocket8888 merged 5 commits into
apache:masterfrom
mhoppa:feature/deprecate_stats_summary_create
Jan 29, 2020
Merged

Add deprecation notices to stats_summary/create#4186
ocket8888 merged 5 commits into
apache:masterfrom
mhoppa:feature/deprecate_stats_summary_create

Conversation

@mhoppa

@mhoppa mhoppa commented Dec 9, 2019

Copy link
Copy Markdown
Contributor

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Build Traffic Ops Perl with changed and make request to stats_summary/create it should now include deprecate notice to use stats_summary

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

###Relies on the PR https://github.com/apache/trafficcontrol/pull/4173###

@mhoppa mhoppa changed the title Add deprecation notices to stats_summary/create WIP - Add deprecation notices to stats_summary/create Dec 9, 2019
@asf-ci

asf-ci commented Dec 9, 2019

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4896/

@mhoppa mhoppa mentioned this pull request Jan 29, 2020
7 tasks
@ocket8888 ocket8888 added tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops labels Jan 29, 2020
@ocket8888 ocket8888 added this to the Go Rewrite milestone Jan 29, 2020
@ocket8888 ocket8888 added the WIP "Work-in-Progress" - do not merge! (use 'draft' pull requests from now on) label Jan 29, 2020
@mhoppa
mhoppa marked this pull request as ready for review January 29, 2020 17:21
@mhoppa
mhoppa requested a review from ocket8888 January 29, 2020 17:22
@mhoppa mhoppa changed the title WIP - Add deprecation notices to stats_summary/create Add deprecation notices to stats_summary/create Jan 29, 2020
@ocket8888 ocket8888 removed the WIP "Work-in-Progress" - do not merge! (use 'draft' pull requests from now on) label Jan 29, 2020
@ocket8888 ocket8888 self-assigned this Jan 29, 2020

@ocket8888 ocket8888 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the deprecation warning appears in all applicable scenarios.

@ocket8888
ocket8888 merged commit 4c8182e into apache:master Jan 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rewrite /stats_summary/create to Go

3 participants