Rewrite stats summary post to golang#4173
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
|
@ocket8888 once you get a chance can you re review?? :) |
ocket8888
left a comment
There was a problem hiding this comment.
All of the actual code and docs changes look fine, but if this is going to close #3833 then it needs to either rewrite or deprecate summary_stats/create (and I'm pretty sure we want the latter). Which would mean a patch in the Perl handler to return a deprecation notice and a line in the CHANGELOG. If you wanna do that in a separate PR that's fine, but then this doesn't close #3833.
|
#4186 already posted waiting for this to merge let me remove the issue from the pull request template so it doesnt close it |
ocket8888
left a comment
There was a problem hiding this comment.
Manual tests confirm it works according to the docs which build without errors or warnings and look fine, all unit and api/client integration tests passing.
What does this PR (Pull Request) do?
Rewrite /stats_summary/create into a new route of /stats_summary
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Additional Information