fix(explore): render Jinja before validating legacy chart filters

[massucattoj]

SUMMARY

Using Jinja templating in a Custom SQL filter (e.g. a HAVING clause) on a legacy chart such as the Time-series Table raises Invalid SQL clause.

Root cause. The legacy viz pipeline validated filter clauses with SQLGlot before rendering Jinja, so the raw template text was parsed as SQL and rejected. This happened in two redundant places:

1. split_adhoc_filters_into_base_filters (superset/utils/core.py)
2. BaseViz.query_obj() (superset/viz.py) - re-sanitized the same clauses right after.

The modern chart-data pipeline doesn't have this problem because it renders the template before validating (QueryObject.validate() → processor.process_template(clause, force=True) → sanitize_clause), which is why only legacy viz types were affected.

Fix. Remove the premature validation instead of duplicating template rendering into the legacy pipeline.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TESTING INSTRUCTIONS

Requires ENABLE_TEMPLATE_PROCESSING: True.

1. Create a Time-series Table chart using the "Vehicle Sales" (cleaned_sales_data) example dataset, with metric SUM(price_each) and one entry in "Time series columns".
2. Add a filter → Custom SQL → clause HAVING →
   sum(price_each) > {% if filter_values('threshold')|length %} {{ filter_values('threshold')[0] }} {% else %} 0 {% endif %}
3. Update the chart.
   • Before: Invalid SQL clause error.
   • After: chart renders; the issued query contains HAVING ((sum(price_each) > 0)).
4. Regression check - replace the filter with genuinely invalid SQL (e.g. sum(price_each) > ) broken () and update: the query is still rejected, by the downstream validator (INVALID_SQL_ERROR with parse position).

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags: ENABLE_TEMPLATE_PROCESSING
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[bito-code-review]

Code Review Agent Run #9c7228

Actionable Suggestions - 0

Review Details

• Files reviewed - 4 · Commit Range: daa3450..daa3450

  • superset/utils/core.py
  • superset/viz.py
  • tests/unit_tests/core_tests.py
  • tests/unit_tests/test_viz_query_obj.py
• Files skipped - 0
• Tools

  • MyPy (Static Code Analysis) - ✔︎ Successful
  • Astral Ruff (Static Code Analysis) - ✔︎ Successful
  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[netlify]

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	184b82e
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/6a54ceaffa05f9000868d6ac
😎 Deploy Preview	https://deploy-preview-41996--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.04%. Comparing base (3c69822) to head (184b82e).
⚠️ Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
superset/utils/core.py	0.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #41996   +/-   ##
=======================================
  Coverage   65.04%   65.04%           
=======================================
  Files        2742     2741    -1     
  Lines      153422   153371   -51     
  Branches    35198    35185   -13     
=======================================
- Hits        99789    99761   -28     
+ Misses      51726    51704   -22     
+ Partials     1907     1906    -1     

Flag	Coverage Δ
hive	39.07% <0.00%> (+<0.01%)	⬆️
mysql	57.96% <0.00%> (+<0.01%)	⬆️
postgres	58.02% <0.00%> (+<0.01%)	⬆️
presto	41.06% <0.00%> (+<0.01%)	⬆️
python	59.40% <0.00%> (+<0.01%)	⬆️
sqlite	57.63% <0.00%> (+<0.01%)	⬆️
unit	100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[rusackas]

LGTM!