Repository navigation
Conversation
…ration (cherry picked from commit 71993fe) Conflicts: core/src/main/scala/org/apache/spark/metrics/MetricsConfig.scala core/src/test/scala/org/apache/spark/metrics/MetricsConfigSuite.scala
Contributor
Author
|
This is a resubmission of #5788 against master, and with feedback applied. |
|
Test build #33920 has finished for PR 6560 at commit
|
|
Test build #33924 has finished for PR 6560 at commit
|
Contributor
Author
|
Ping @andrewor14 @pwendell . Pretty straight-forward change. |
Contributor
There was a problem hiding this comment.
probably doesn't need to be an instance variable since it's only used in 1 place
Contributor
|
LGTM. Pretty straightforward indeed. All my comments are nits. |
Contributor
|
Ok, merging into master once tests pass. Thanks @vanzin @jlewandowski |
|
Test build #34301 has finished for PR 6560 at commit
|
vanzin
pushed a commit
that referenced
this pull request
Jun 7, 2015
…rkConf. Author: Marcelo Vanzin <vanzin@cloudera.com> Author: Jacek Lewandowski <lewandowski.jacek@gmail.com> Closes #6560 from vanzin/SPARK-7169 and squashes the following commits: 737266f [Marcelo Vanzin] Feedback. 702d5a3 [Marcelo Vanzin] Scalastyle. ce66e7e [Marcelo Vanzin] Remove metrics config handling from SparkConf. 439938a [Jacek Lewandowski] SPARK-7169: Metrics can be additionally configured from Spark configuration
nemccarthy
pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 19, 2015
…rkConf. Author: Marcelo Vanzin <vanzin@cloudera.com> Author: Jacek Lewandowski <lewandowski.jacek@gmail.com> Closes apache#6560 from vanzin/SPARK-7169 and squashes the following commits: 737266f [Marcelo Vanzin] Feedback. 702d5a3 [Marcelo Vanzin] Scalastyle. ce66e7e [Marcelo Vanzin] Remove metrics config handling from SparkConf. 439938a [Jacek Lewandowski] SPARK-7169: Metrics can be additionally configured from Spark configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.