Skip to content

Adjust spec version to differ from Apache NetBeans 14 for java/libs.nbjavac #4045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebarboni merged 1 commit into from
Apr 29, 2022
Merged

Adjust spec version to differ from Apache NetBeans 14 for java/libs.nbjavac #4045

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion java/libs.nbjavacapi/manifest.mf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
AutoUpdate-Show-In-Client: true
OpenIDE-Module: org.netbeans.libs.nbjavacapi
OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/nbjavac/api/Bundle.properties
OpenIDE-Module-Specification-Version: 18.0
OpenIDE-Module-Specification-Version: 18.1
Copy link
Copy Markdown
Member

@mbien mbien Apr 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this be 18.0.0.1? Because there might be a 18.0.1 nb-javac.

Copy link
Copy Markdown
Member

@neilcsmith-net neilcsmith-net Apr 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be ideal, but checking 8da225d the spec version task always increments the second number even when there are further dots, so I think keeping the major number in sync is about all we can do. Perhaps look at 18.1.1, 18.1.2 if we really want to have the JDK update in there too?? 🤷

Copy link
Copy Markdown
Contributor Author

@ebarboni ebarboni Apr 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbien noted but not ideal to spec task. and time to update the text we would be on jdk 19 ( joking :D sorry hard time waiting for travis )

Copy link
Copy Markdown
Member

@mbien mbien Apr 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have to write this somewhere down. Because this all looks like an accident in the making :)

OpenIDE-Module-Hide-Classpath-Packages: com.sun.javadoc.**, com.sun.source.**, javax.annotation.processing.**, javax.lang.model.**, javax.tools.**, com.sun.tools.javac.** com.sun.tools.javac.**, com.sun.tools.javadoc.**, com.sun.tools.javap.**, com.sun.tools.classfile.**, com.sun.tools.doclint.**
OpenIDE-Module-Fragment-Host: org.netbeans.libs.javacapi
OpenIDE-Module-Provides: org.netbeans.libs.nbjavac