Skip to content

Adjust spec version to differ from Apache NetBeans 14 for java/libs.nbjavac#4045

Merged
ebarboni merged 1 commit into
apache:masterfrom
ebarboni:specversionlibsnbjaavac
Apr 29, 2022
Merged

Adjust spec version to differ from Apache NetBeans 14 for java/libs.nbjavac#4045
ebarboni merged 1 commit into
apache:masterfrom
ebarboni:specversionlibsnbjaavac

Conversation

@ebarboni
Copy link
Copy Markdown
Contributor

Related to #4040

Copy link
Copy Markdown
Contributor

@singh-akhilesh singh-akhilesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebarboni ebarboni added this to the NB15 milestone Apr 28, 2022
OpenIDE-Module: org.netbeans.libs.nbjavacapi
OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/nbjavac/api/Bundle.properties
OpenIDE-Module-Specification-Version: 18.0
OpenIDE-Module-Specification-Version: 18.1
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this be 18.0.0.1? Because there might be a 18.0.1 nb-javac.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be ideal, but checking 8da225d the spec version task always increments the second number even when there are further dots, so I think keeping the major number in sync is about all we can do. Perhaps look at 18.1.1, 18.1.2 if we really want to have the JDK update in there too?? 🤷

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbien noted but not ideal to spec task. and time to update the text we would be on jdk 19 ( joking :D sorry hard time waiting for travis )

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have to write this somewhere down. Because this all looks like an accident in the making :)

Copy link
Copy Markdown
Member

@neilcsmith-net neilcsmith-net left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebarboni ebarboni merged commit 71f182d into apache:master Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants