Skip to content

Spark 3.5: Add Parallelism Parameter Validation to AddFilesProcedure. #12784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nastra merged 4 commits into from
Apr 22, 2025
Merged

Spark 3.5: Add Parallelism Parameter Validation to AddFilesProcedure. #12784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9abeddd
Spark 3.5: Add Parallelism Parameter Validation to AddFilesProcedure.
slfan1989 Apr 12, 2025
5a098f8
Update spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/s…
slfan1989 Apr 14, 2025
4b36dc4
Spark 3.5: Improve Some codes.
slfan1989 Apr 14, 2025
f100ec0
Spark: Fix CheckStyle Issue.
slfan1989 Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions ...k-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1109,6 +1109,22 @@ public void testAddFilesPartitionedWithParallelism() {
sql("SELECT id, name, dept, subdept FROM %s ORDER BY id", tableName));
}

@TestTemplate
public void testAddFilesWithInvalidParallelism() {
createUnpartitionedHiveTable();

createIcebergTable(
"id Integer, name String, dept String, subdept String", "PARTITIONED BY (id)");

assertThatThrownBy(
() ->
sql(
"CALL %s.system.add_files(table => '%s', source_table => '%s', parallelism => -1)",

@ebyhr ebyhr Apr 15, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Testing with the boundary value 0 is more natural. I know testMigrateWithInvalidParallelism uses -1, though.

catalogName, tableName, sourceTableName))
.isInstanceOf(IllegalArgumentException.class)
.hasMessage("Parallelism should be larger than 0");
}

@TestTemplate
public void testAddFilesToTableWithManySpecs() {
createPartitionedHiveTable();
Expand Down
1 change: 1 addition & 0 deletions spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/AddFilesProcedure.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ public InternalRow[] call(InternalRow args) {
boolean checkDuplicateFiles = input.asBoolean(CHECK_DUPLICATE_FILES_PARAM, true);

int parallelism = input.asInt(PARALLELISM, 1);
Preconditions.checkArgument(parallelism > 0, "Parallelism should be larger than 0");

return importToIceberg(
tableIdent, sourceIdent, partitionFilter, checkDuplicateFiles, parallelism);
Expand Down