Repository navigation
Spark 3.5: Add Parallelism Parameter Validation to AddFilesProcedure. - #12784
Merged
Merged
Conversation
ebyhr
reviewed
Apr 13, 2025
| () -> | ||
| sql( | ||
| "CALL %s.system.add_files(table => '%s', source_table => '%s', parallelism => %d)", | ||
| catalogName, tableName, sourceTableName, -1)) |
Contributor
Author
There was a problem hiding this comment.
Thank you for your suggestions. I have already made the changes to the code.
…park/extensions/TestAddFilesProcedure.java Co-authored-by: Yuya Ebihara <ebyhry@gmail.com>
Contributor
Author
|
@manuzhang @ebyhr Could you help review this PR? Thank you very much! |
manuzhang
approved these changes
Apr 15, 2025
ebyhr
approved these changes
Apr 15, 2025
| assertThatThrownBy( | ||
| () -> | ||
| sql( | ||
| "CALL %s.system.add_files(table => '%s', source_table => '%s', parallelism => -1)", |
Member
There was a problem hiding this comment.
nit: Testing with the boundary value 0 is more natural. I know testMigrateWithInvalidParallelism uses -1, though.
Contributor
Author
|
@manuzhang Thank you for the review and approval! If there are no further issues, could you please merge this PR? |
Member
|
@slfan1989 It requires an approval from a committer. |
Contributor
Author
@manuzhang Thank you for your message! @nastra Could you take a look at this PR? Thank you very much! |
nastra
approved these changes
Apr 22, 2025
Contributor
Author
|
@nastra @manuzhang @ebyhr Thank you very much for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spark 3.5: Add Parallelism Parameter Validation to AddFilesProcedure.