Repository navigation
[GLUTEN-9995][CORE] Source folder control for different Spark versions in all Maven modules - #9996
Merged
Merged
Conversation
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
Member
Author
|
There are a couple of test source files for Iceberg that won't compile under Spark versions other than 3.4. I am moving them to src-iceberg-spark34 in this PR. Let me know if you have comments on that.
|
jinchengchenghh
approved these changes
Jun 18, 2025
jinchengchenghh
left a comment
jinchengchenghh
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks for your refactor
zhztheplayer
marked this pull request as ready for review
June 18, 2025 07:16
This was referenced Aug 31, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #9995 which is implemented by this PR.
The PR adds the new default src folders for all Maven modules.
The new folder layout in IDE:
This will fix a series of strange Maven errors both in IDE and Maven CLI for Iceberg support development.