Skip to content

[VL] Fix Java tests not test #10011

Description

@jinchengchenghh

Backend

VL (Velox)

Bug description

https://github.com/apache/incubator-gluten/pull/8930/ marks plugin maven-surefire-plugin configuration skipTests as true, so all the tests don't test.
And need to fix some tests.
[INFO] Results:
[3097](https://github.com/apache/incubator-gluten/actions/runs/15749015147/job/44391416028?pr=9927#step:7:3098)
[INFO] 
[3098](https://github.com/apache/incubator-gluten/actions/runs/15749015147/job/44391416028?pr=9927#step:7:3099)
Error:  Failures: 
[3099](https://github.com/apache/incubator-gluten/actions/runs/15749015147/job/44391416028?pr=9927#step:7:3100)
Error:    ArrowFilesystemTest.testBaseCsvRead Multiple Failures (2 failures)
[3100](https://github.com/apache/incubator-gluten/actions/runs/15749015147/job/44391416028?pr=9927#step:7:3101)
	java.lang.NoClassDefFoundError: Could not initialize class org.apache.arrow.memory.RootAllocator
[3101](https://github.com/apache/incubator-gluten/actions/runs/15749015147/job/44391416028?pr=9927#step:7:3102)
	java.lang.NullPointerException: Cannot invoke "org.apache.arrow.memory.RootAllocator.close()" because "this.allocator" is null
[3102](https://github.com/apache/incubator-gluten/actions/runs/15749015147/job/44391416028?pr=9927#step:7:3103)
Error:    OnHeapFileSystemTest.testRoundTrip:38
[3103](https://github.com/apache/incubator-gluten/actions/runs/15749015147/job/44391416028?pr=9927#step:7:3104)
Error:  Errors: 
[3104](https://github.com/apache/incubator-gluten/actions/runs/15749015147/job/44391416028?pr=9927#step:7:3105)
Error:    ColumnarBatchTest.testCompose:180->lambda$testCompose$7:183->newArrowBatch:244 ? NoClassDefFound Could not initialize class org.apache.arrow.memory.RootAllocator
[3105](https://github.com/apache/incubator-gluten/actions/runs/15749015147/job/44391416028?pr=9927#step:7:3106)
Error:    ColumnarBatchTest.testCreateByHandle:110->lambda$testCreateByHandle$5:113->newArrowBatch:244 ? NoClassDefFound Could not initialize class org.apache.arrow.memory.RootAllocator
[3106](https://github.com/apache/incubator-gluten/actions/runs/15749015147/job/44391416028?pr=9927#step:7:3107)
Error:    ColumnarBatchTest.testOffloadAndLoad:44->lambda$testOffloadAndLoad$3:47->newArrowBatch:244 ? NoClassDefFound Could not initialize class org.apache.arrow.memory.RootAllocator
[3107](https://github.com/apache/incubator-gluten/actions/runs/15749015147/job/44391416028?pr=9927#step:7:3108)
Error:    ColumnarBatchTest.testReadRow:147->lambda$testReadRow$6:150->newArrowBatch:244 ? NoClassDefFound Could not initialize class org.apache.arrow.memory.RootAllocator
[3108](https://github.com/apache/incubator-gluten/actions/runs/15749015147/job/44391416028?pr=9927#step:7:3109)
Error:    ColumnarBatchTest.testToString:214->lambda$testToString$8:217->newArrowBatch:244 ? NoClassDefFound Could not initialize class org.apache.arrow.memory.RootAllocator
[3109](https://github.com/apache/incubator-gluten/actions/runs/15749015147/job/44391416028?pr=9927#step:7:3110)
Error:    ColumnarBatchTest.testZeroColumnBatch:78->lambda$testZeroColumnBatch$4:87 ? ExceptionInInitializer
[3110](https://github.com/apache/incubator-gluten/actions/runs/15749015147/job/44391416028?pr=9927#step:7:3111)
Error:    ArrowColumnVectorTest.testWriteByMutableColumnarRow:30->lambda$testWriteByMutableColumnarRow$0:32->newArrowColumns:44 ? NoClassDefFound Could not initialize class org.apache.arrow.memory.RootAllocator
[3111](https://github.com/apache/incubator-gluten/actions/runs/15749015147/job/44391416028?pr=9927#step:7:3112)
[INFO]

Activity

  1. jinchengchenghh commented on Jun 19, 2025

    @jinchengchenghh
    ContributorAuthor
    [INFO] Running org.apache.gluten.fs.OnHeapFileSystemTest
    [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0 s <<< FAILURE! -- in org.apache.gluten.fs.OnHeapFileSystemTest
    [ERROR] org.apache.gluten.fs.OnHeapFileSystemTest.testRoundTrip -- Time elapsed: 0 s <<< FAILURE!
    java.lang.AssertionError
    	at io.netty.util.internal.PlatformDependent.allocateDirectNoCleaner(PlatformDependent.java:729)
    	at org.apache.gluten.fs.OnHeapFileSystemTest.testRoundTrip(OnHeapFileSystemTest.java:38)
    	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
    	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
    
  2. zhztheplayer commented on Jun 19, 2025

    @zhztheplayer
    Member

    @apache/gluten-committers

    Guys, please pause on merging PRs at the moment. Let's get this issue fixed first, otherwise all Java tests may not be run on CI.

    We don't have many Java tests so this should not take long to fix.

  3. FelixYBW commented on Jun 19, 2025

    @FelixYBW
    Contributor

    What's the issue?

  4. zhztheplayer commented on Jun 19, 2025

    @zhztheplayer
    Member

    @FelixYBW Could be related to some pom settings on surefire option 'skipTests', we can do a trivial fix to enable the base test first.

    @jinchengchenghh I ran locally all the Java tests (except for CH backend) and saw some Iceberg test failures:

    [ERROR] Failures: 
    [ERROR] org.apache.iceberg.spark.source.TestSparkReaderDeletes.testMultiplePosDeleteFiles
    [ERROR]   Run 1: TestSparkReaderDeletes>DeleteReadTests.testMultiplePosDeleteFiles:445->DeleteReadTests.checkDeleteCount:211 [Table should contain expected number of deletes] 
    expected: 3L
     but was: 0L
    [ERROR]   Run 2: TestSparkReaderDeletes>DeleteReadTests.testMultiplePosDeleteFiles:445->DeleteReadTests.checkDeleteCount:211 [Table should contain expected number of deletes] 
    expected: 3L
     but was: 0L
    [ERROR]   Run 3: TestSparkReaderDeletes>DeleteReadTests.testMultiplePosDeleteFiles:445->DeleteReadTests.checkDeleteCount:211 [Table should contain expected number of deletes] 
    expected: 3L
     but was: 0L
    

    (Hopefully they are not related to my work on #9996)

    We may be able to disable these tests first (add @ignore on the classes) and send a PR to enable other Java tests first? To unblock other ongoing PRs from merging.

  5. zhztheplayer commented on Jun 19, 2025

    @zhztheplayer
    Member

    @apache/gluten-committers

    I had a local test and the Java tests are basically still passing (except for some iceberg test), it should be fine to continue on merging PRs, sorry for the waiting here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions