Skip to content

[GLUTEN][VL] Enable velox parquet write suite #3039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rui-mo merged 1 commit into from
Sep 6, 2023
Merged

[GLUTEN][VL] Enable velox parquet write suite #3039

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions cpp/velox/operators/writer/VeloxParquetDatasource.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,15 @@ void VeloxParquetDatasource::init(const std::unordered_map<std::string, std::str
auto backend = std::dynamic_pointer_cast<gluten::VeloxBackend>(gluten::createBackend());

if (strncmp(filePath_.c_str(), "file:", 5) == 0) {
// sink_ = std::make_unique<velox::dwio::common::LocalFileSink>(filePath_.substr(5));
auto path = filePath_.substr(5);
auto localWriteFile = std::make_unique<LocalWriteFile>(path, true, false);
sink_ = std::make_unique<WriteFileSink>(std::move(localWriteFile), path);
} else if (strncmp(filePath_.c_str(), "hdfs:", 5) == 0) {
#ifdef ENABLE_HDFS
std::string pathSuffix = getHdfsPath(filePath_, HdfsFileSystem::kScheme);
auto fileSystem = getFileSystem(filePath_, nullptr);
auto* hdfsFileSystem = dynamic_cast<filesystems::HdfsFileSystem*>(fileSystem.get());
// sink_ = std::make_unique<WriteFileSink>(hdfsFileSystem->openFileForWrite(pathSuffix), filePath_);
sink_ = std::make_unique<WriteFileSink>(hdfsFileSystem->openFileForWrite(pathSuffix), filePath_);
#else
throw std::runtime_error(
"The write path is hdfs path but the HDFS haven't been enabled when writing parquet data in velox backend!");
Expand Down Expand Up @@ -105,6 +107,7 @@ void VeloxParquetDatasource::init(const std::unordered_map<std::string, std::str
return std::make_unique<velox::parquet::LambdaFlushPolicy>(
maxRowGroupRows_, maxRowGroupRows_, [&]() { return false; });
};
writeOption.schema = schema_;

parquetWriter_ = std::make_unique<velox::parquet::Writer>(std::move(sink_), writeOption, pool_);
}
Expand Down