Repository navigation
[GLUTEN][VL] Enable velox parquet write suite - #3039
Merged
rui-mo merged 1 commit intoSep 6, 2023
Merged
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
Contributor
Author
|
@rui-mo @marin-ma oap-project/velox#370 has not been submitted to Velox upstream yet. It is pending facebookincubator/velox#6074. We can disable this |
rui-mo
approved these changes
Sep 6, 2023
rui-mo
left a comment
rui-mo
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the quick fix!
rui-mo
pushed a commit
to rui-mo/gazelle-jni
that referenced
this pull request
Sep 11, 2023
rui-mo
pushed a commit
to rui-mo/gazelle-jni
that referenced
this pull request
Sep 13, 2023
rui-mo
pushed a commit
to rui-mo/gazelle-jni
that referenced
this pull request
Sep 15, 2023
rui-mo
pushed a commit
to rui-mo/gazelle-jni
that referenced
this pull request
Sep 21, 2023
rui-mo
pushed a commit
to rui-mo/gazelle-jni
that referenced
this pull request
Sep 25, 2023
rui-mo
pushed a commit
to rui-mo/gazelle-jni
that referenced
this pull request
Oct 7, 2023
rui-mo
pushed a commit
to rui-mo/gazelle-jni
that referenced
this pull request
Oct 16, 2023
rui-mo
pushed a commit
to rui-mo/gazelle-jni
that referenced
this pull request
Oct 16, 2023
rui-mo
pushed a commit
to rui-mo/gazelle-jni
that referenced
this pull request
Oct 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Pass the parquet write suite except parquet write with empty dataframe, which need oap-project/velox#370.
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)