Skip to content

[CH] Support json_tuple function - #1135

Merged
zzcclp merged 1 commit into
apache:mainfrom
KevinyhZou:support_json_tuple_function
Jun 5, 2023
Merged

[CH] Support json_tuple function#1135
zzcclp merged 1 commit into
apache:mainfrom
KevinyhZou:support_json_tuple_function

Conversation

@KevinyhZou

@KevinyhZou KevinyhZou commented Mar 15, 2023

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Support json_tuple funtion for spark in clickhouse backend, the related pr: Kyligence/ClickHouse#361

How was this patch tested?

test by unit test

@github-actions

Copy link
Copy Markdown

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[Gluten-${ISSUES_ID}] ${detailed message}

See also:

Comment on lines 335 to 339

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change:

          val children = j.children.map(child =>
          replaceWithExpressionTransformer(child, attributeSeq))

@zzcclp

zzcclp commented Mar 20, 2023

Copy link
Copy Markdown
Contributor

please add some ut for this function, btw, it may need to support this function in ch backend?

@KevinyhZou

Copy link
Copy Markdown
Contributor Author

please add some ut for this function, btw, it may need to support this function in ch backend?

ok, I will add some ut. and I have support this function in ch backend in pr : ClickHouse/ClickHouse#47343

but I think this also can archive by JsonExtract function, i will open the pr to see whether it can be accpeted by clickhouse

@KevinyhZou
KevinyhZou force-pushed the support_json_tuple_function branch from 699edc0 to ad37fec Compare March 28, 2023 13:17
@KevinyhZou

Copy link
Copy Markdown
Contributor Author

please add some ut for this function, btw, it may need to support this function in ch backend?

ut added done. @zzcclp

@zzcclp zzcclp changed the title [CK] Support json_tuple function [CH] Support json_tuple function Mar 30, 2023
@kyligence-git

Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

@KevinyhZou
KevinyhZou force-pushed the support_json_tuple_function branch 2 times, most recently from bf83190 to 0643fc6 Compare April 19, 2023 03:19
@KevinyhZou

Copy link
Copy Markdown
Contributor Author

cc @zzcclp @liuneng1994

@KevinyhZou
KevinyhZou force-pushed the support_json_tuple_function branch from 98ed105 to 09f31ee Compare June 2, 2023 06:32
@github-actions

github-actions Bot commented Jun 2, 2023

Copy link
Copy Markdown

Run Gluten Clickhouse CI

@KevinyhZou
KevinyhZou force-pushed the support_json_tuple_function branch from 09f31ee to 3690ec8 Compare June 2, 2023 06:53
@github-actions

github-actions Bot commented Jun 2, 2023

Copy link
Copy Markdown

Run Gluten Clickhouse CI

@liuneng1994 liuneng1994 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzcclp zzcclp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzcclp
zzcclp merged commit d84ca65 into apache:main Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants