Skip to content

[CH-358]Support json_tuple function - #361

Merged
liuneng1994 merged 3 commits into
Kyligence:clickhouse_backendfrom
KevinyhZou:support_json_tuple
Apr 13, 2023
Merged

[CH-358]Support json_tuple function#361
liuneng1994 merged 3 commits into
Kyligence:clickhouse_backendfrom
KevinyhZou:support_json_tuple

Conversation

@KevinyhZou

@KevinyhZou KevinyhZou commented Mar 15, 2023 •
edited
Loading

Copy link
Copy Markdown

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Implement json_tuple funtion by use JSONExtract function in ck, the releated issue: #358

  1. convert json_tuple to JSONExtract function;
  2. convert json_tuple result to multi columns likes spark json_tuple

@kyligence-git

kyligence-git commented Mar 15, 2023

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

This was referenced Mar 15, 2023
Closed
Merged
@liuneng1994

liuneng1994 commented Mar 17, 2023

Copy link
Copy Markdown

test this please

@zzcclp

zzcclp commented Mar 17, 2023

Copy link
Copy Markdown
Collaborator

please add a gluten pr to add some ut for this function, thanks

@KevinyhZou

KevinyhZou commented Mar 25, 2023

Copy link
Copy Markdown
Author

please add a gluten pr to add some ut for this function, thanks

ok

@KevinyhZou

KevinyhZou commented Mar 28, 2023

Copy link
Copy Markdown
Author

please add a gluten pr to add some ut for this function, thanks

ut added done in gluten pr: apache/gluten#1135. Thanks for your review @zzcclp

@liuneng1994

liuneng1994 commented Mar 30, 2023

Copy link
Copy Markdown

test this please

@liuneng1994

liuneng1994 commented Mar 30, 2023

Copy link
Copy Markdown

test this please with 1135

1 similar comment
@liuneng1994

liuneng1994 commented Mar 30, 2023

Copy link
Copy Markdown

test this please with 1135

liuneng1994
liuneng1994 reviewed Mar 31, 2023
View reviewed changes
Comment thread utils/local-engine/Parser/SerializedPlanParser.cpp Outdated

@liuneng1994 liuneng1994 Mar 31, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里有编译警告

@KevinyhZou KevinyhZou Apr 2, 2023

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix done. @liuneng1994

@KevinyhZou
KevinyhZou force-pushed the support_json_tuple branch from 0453e1a to f6be52b Compare April 2, 2023 13:32
@liuneng1994

liuneng1994 commented Apr 6, 2023

Copy link
Copy Markdown

test this please with 1135

@KevinyhZou

KevinyhZou commented Apr 12, 2023

Copy link
Copy Markdown
Author

test this please with 1135

@KevinyhZou

KevinyhZou commented Apr 12, 2023

Copy link
Copy Markdown
Author

@liuneng1994 cc

liuneng1994
liuneng1994 approved these changes Apr 13, 2023
View reviewed changes

@liuneng1994 liuneng1994 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuneng1994
liuneng1994 merged commit 2b37553 into Kyligence:clickhouse_backend Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@liuneng1994 liuneng1994 liuneng1994 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@KevinyhZou @kyligence-git @liuneng1994 @zzcclp