Skip to content

Remove Query ID verification check from MSQ workers - #16886

Merged
LakshSingla merged 2 commits into
apache:masterfrom
LakshSingla:msq-query-id-verification
Aug 14, 2024
Merged

LakshSingla merged 2 commits into
apache:masterfrom
LakshSingla:msq-query-id-verification

Conversation

@LakshSingla

@LakshSingla LakshSingla commented Aug 13, 2024 •

Copy link
Copy Markdown
Contributor

Description

Recent refactors to MSQ introduced a sanity check to verify that the query ID received by the worker during its communication with the controller is correct. However, there was a pre-existing bug in Druid where the query ids for each individual stage can be populated with random UUIDs instead of the correct value. Upgrade/Downgrade between any version till or before Druid 30 where the newer version runs a worker task, while the older version runs a controller task can fail. This PR removes that verification check till its safe to add it back.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@github-actions github-actions Bot added Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 labels Aug 13, 2024
@LakshSingla
LakshSingla merged commit 204533c into apache:master Aug 14, 2024
@LakshSingla
LakshSingla deleted the msq-query-id-verification branch August 14, 2024 04:52
@kfaraz kfaraz added this to the 31.0.0 milestone Oct 4, 2024
riovic918data pushed a commit to riovic918data/druid that referenced this pull request Jun 12, 2026
Upgrade/Downgrade between any version till or before Druid 30 where the newer version runs a worker task, while the older version runs a controller task can fail. The patch removes that verification check till its safe to add it back.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants