Repository navigation
Remove Query ID verification check from MSQ workers - #16886
Merged
LakshSingla merged 2 commits intoAug 14, 2024
Merged
Conversation
cryptoe
approved these changes
Aug 13, 2024
riovic918data
pushed a commit
to riovic918data/druid
that referenced
this pull request
Jun 12, 2026
Upgrade/Downgrade between any version till or before Druid 30 where the newer version runs a worker task, while the older version runs a controller task can fail. The patch removes that verification check till its safe to add it back.
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Recent refactors to MSQ introduced a sanity check to verify that the query ID received by the worker during its communication with the controller is correct. However, there was a pre-existing bug in Druid where the query ids for each individual stage can be populated with random UUIDs instead of the correct value. Upgrade/Downgrade between any version till or before Druid 30 where the newer version runs a worker task, while the older version runs a controller task can fail. This PR removes that verification check till its safe to add it back.
This PR has: