Skip to content

Add back Query ID verification check from MSQ workers #16894

Closed

Description

@LakshSingla

Description

Until and before Druid 30, the query IDs of different stages in MSQ were populated randomly, but we never really relied on them. It was incorrect behavior which was fixed in #16168. Later, a query ID verification check was added to make sure that different stages of a query have the same query ID. However, it isn't safe to do so till we have to maintain backward compatibility with Druid 30, which would be till Druid 34 is released. #16886 removed the query id verification check, that should be added back once that happens.

Activity

  1. nanjeshramesh commented on Oct 8, 2026

    @nanjeshramesh
    Contributor

    I would like to take this. The condition in the description is met: the latest stable release is 38 and the compatibility window for versions up to 30 has passed. verifyQueryId is still missing on master, so I will restore it as it was before #16886 (the four KernelHolders call sites in WorkerImpl plus the helper) and remove the note from the StageId Javadoc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area - MSQFor multi stage queries - https://github.com/apache/druid/issues/12262RefactoringStarter

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions