You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add back Query ID verification check from MSQ workers #16894
Until and before Druid 30, the query IDs of different stages in MSQ were populated randomly, but we never really relied on them. It was incorrect behavior which was fixed in #16168. Later, a query ID verification check was added to make sure that different stages of a query have the same query ID. However, it isn't safe to do so till we have to maintain backward compatibility with Druid 30, which would be till Druid 34 is released. #16886 removed the query id verification check, that should be added back once that happens.
I would like to take this. The condition in the description is met: the latest stable release is 38 and the compatibility window for versions up to 30 has passed. verifyQueryId is still missing on master, so I will restore it as it was before #16886 (the four KernelHolders call sites in WorkerImpl plus the helper) and remove the note from the StageId Javadoc.
Activity
nanjeshramesh commentedon Oct 8, 2026
I would like to take this. The condition in the description is met: the latest stable release is 38 and the compatibility window for versions up to 30 has passed.
verifyQueryIdis still missing on master, so I will restore it as it was before #16886 (the fourKernelHolderscall sites inWorkerImplplus the helper) and remove the note from theStageIdJavadoc.