Repository navigation
Whitelisting Onelake API & Workspace PL FQDNs - #711
Merged
Merged
Conversation
* Whitelisting Onelake API & Workspace PL FQDNs * Addressing comments to whitelist api-onelake fqdns and add UTs * Reverting the mistakenly modified UT * Adding validation for xy in WS-PL URL & case insensitive regex * Making regex an optional dependency * Eliminating the use of regex for ws-pl fqdn matching * Adding a separte method 'azure_test_workspace_private_link' for ws-pl tests * Organising private link UTs * Adding integration test for WSPL & rebasing with unpstream * Whitelisting Onelake API & Workspace PL FQDNs * Addressing comments to whitelist api-onelake fqdns and add UTs * Reverting the mistakenly modified UT * Adding validation for xy in WS-PL URL & case insensitive regex * Making regex an optional dependency * Eliminating the use of regex for ws-pl fqdn matching * Adding a separte method 'azure_test_workspace_private_link' for ws-pl tests * Organising private link UTs * Fixing cargo fmt * Fixing Clippy * Fixing Clippy * Fixing Clippy * Modified Integration test to pass workspace & artifact id within URL only * Fixing Clippy * Adding WSPL support for ABFSS scheme as well * Adding comments for readability * Adding comments for readability --------- Co-authored-by: Smriti Agrawal <smagrawal@microsoft.com>
kevinjqliu
approved these changes
May 6, 2026
kevinjqliu
left a comment
kevinjqliu
left a comment
Contributor
There was a problem hiding this comment.
LGTM
I have been working with @SmritiAgrawal04 on this. We ran integration tests and validated this against WSPL test environment. We also wired this local change with delta-rs to validate that delta-rs can read abfss:// uri string for WSPL
Contributor
|
@tustvold could you take a look when you get a chance? |
18 tasks done
alamb
approved these changes
Jun 11, 2026
alamb
left a comment
alamb
left a comment
Contributor
There was a problem hiding this comment.
Thank you @SmritiAgrawal04 and @kevinjqliu
| } | ||
| } | ||
|
|
||
| #[ignore = "Used for manual testing against a real Workspace Private Link Endpoint."] |
Contributor
There was a problem hiding this comment.
@crepererum and I were talking the other day and it might be a good idea to get access to a real azure bucket to test against -- perhaps @kevinjqliu could help facilitate this somehow (I am not sure the best way to integrate real integration tests)
This was referenced Jun 17, 2026
This was referenced Jun 25, 2026
This was referenced Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
What changes are included in this PR?
c.microsoft.com/3f49a318-25a0-4100-948d-d08229390322/Files/test_delta_table
Testing Details
WS-PL hosts
{workspaceid}.z{xy}.msit-dfs.fabric.microsoft.com
~ https://7c09f7b8d05f4a0d9534c3cad6e25525.z7c.msit-dfs.fabric.microsoft.com/7c09f7b8-d05f-4a0d-9534-c3cad6e25525/3f49a318-25a0-4100-948d-d08229390322/Files/integration_test_wspl.txt
~ abfss://7c09f7b8-d05f-4a0d-9534-c3cad6e25525@7c09f7b8d05f4a0d9534c3cad6e25525.z7c.msit-dfs.fabric.microsoft.com/3f49a318-25a0-4100-948d-d08229390322/Files/integration_test_wspl.txt
TABLE_URI = '' abfss://7c09f7b8-d05f-4a0d-9534-c3cad6e25525@7c09f7b8d05f4a0d9534c3cad6e25525.z7c.msit-blob.fabric.microsoft.com/3f49a318-25a0-4100-948d-d08229390322/Tables/dbo/wspltesttable" cargo run -p deltalake --example basic_operations --features 'azure,datafusion'Are there any user-facing changes?
Yes. The documentaion is as below: