[v3-3-test] Drop colored logging from the Go SDK edge worker (#70824) - #70908
Merged
Merged
Conversation
…70824) * Drop colored logging from the Go SDK edge worker The Go SDK edge worker was the only Edge Worker that colorized its console logs. The Python Edge Worker (edge3 provider) does not support colored logging, so the Go side aligns with it and drops the feature rather than maintaining coloring the rest of the Edge Worker surface does not offer. Dropping colored logging removes the sole use of the github.com/MatusOllah/ slogcolor dependency; the edge worker now logs via the standard library slog text handler, preserving log levels including the custom TRACE level. The lang-SDK Go example module, which resolves the SDK via a replace directive, is re-tidied to drop the now-unused indirect slogcolor entry. * Reconcile lang-SDK Go example go.sum before building the bundle The K8S Lang-SDK test always builds the Go bundle from upstream main's go-sdk, while go_example is a branch fixture whose go.sum is tidied against the in-repo go-sdk. When a branch changes go-sdk's dependency graph the two go-sdks diverge, and Go refuses to build the bundle on the resulting go.sum drift ("missing go.sum entry ..."), turning the bundle-build step red on the pull request. Re-tidy the scratch go_example against the go-sdk it is actually compiled against before packing so the build reconciles the drift itself; the committed go.sum is left untouched and stays guarded by the check-go-example-mod-tidy prek hook. (cherry picked from commit 802ffa7) Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
jason810496
requested review from
amoghrajesh,
ashb,
gopidesupavan and
potiuk
as code owners
August 1, 2026 13:57
jason810496
marked this pull request as draft
August 1, 2026 14:11
potiuk
marked this pull request as ready for review
August 1, 2026 14:23
Contributor
|
Hi maintainer, this PR was merged without a milestone set.
|
1 task
vatsrahul1001
pushed a commit
that referenced
this pull request
Aug 5, 2026
…#70908) * Drop colored logging from the Go SDK edge worker The Go SDK edge worker was the only Edge Worker that colorized its console logs. The Python Edge Worker (edge3 provider) does not support colored logging, so the Go side aligns with it and drops the feature rather than maintaining coloring the rest of the Edge Worker surface does not offer. Dropping colored logging removes the sole use of the github.com/MatusOllah/ slogcolor dependency; the edge worker now logs via the standard library slog text handler, preserving log levels including the custom TRACE level. The lang-SDK Go example module, which resolves the SDK via a replace directive, is re-tidied to drop the now-unused indirect slogcolor entry. * Reconcile lang-SDK Go example go.sum before building the bundle The K8S Lang-SDK test always builds the Go bundle from upstream main's go-sdk, while go_example is a branch fixture whose go.sum is tidied against the in-repo go-sdk. When a branch changes go-sdk's dependency graph the two go-sdks diverge, and Go refuses to build the bundle on the resulting go.sum drift ("missing go.sum entry ..."), turning the bundle-build step red on the pull request. Re-tidy the scratch go_example against the go-sdk it is actually compiled against before packing so the build reconciles the drift itself; the committed go.sum is left untouched and stays guarded by the check-go-example-mod-tidy prek hook. (cherry picked from commit 802ffa7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Go SDK edge worker was the only Edge Worker that colorized its console logs. The Python Edge Worker (edge3 provider) does not support colored logging, so the Go side aligns with it and drops the feature rather than maintaining coloring the rest of the Edge Worker surface does not offer.
Dropping colored logging removes the sole use of the github.com/MatusOllah/ slogcolor dependency; the edge worker now logs via the standard library slog text handler, preserving log levels including the custom TRACE level. The lang-SDK Go example module, which resolves the SDK via a replace directive, is re-tidied to drop the now-unused indirect slogcolor entry.
The K8S Lang-SDK test always builds the Go bundle from upstream main's go-sdk, while go_example is a branch fixture whose go.sum is tidied against the in-repo go-sdk. When a branch changes go-sdk's dependency graph the two go-sdks diverge, and Go refuses to build the bundle on the resulting go.sum drift ("missing go.sum entry ..."), turning the bundle-build step red on the pull request. Re-tidy the scratch go_example against the go-sdk it is actually compiled against before packing so the build reconciles the drift itself; the committed go.sum is left untouched and stays guarded by the check-go-example-mod-tidy prek hook.
(cherry picked from commit 802ffa7)