Drop colored logging from the Go SDK edge worker - #70824
Merged
jason810496 merged 2 commits intoAug 1, 2026
Merged
Conversation
The Go SDK edge worker was the only Edge Worker that colorized its console logs. The Python Edge Worker (edge3 provider) does not support colored logging, so the Go side aligns with it and drops the feature rather than maintaining coloring the rest of the Edge Worker surface does not offer. Dropping colored logging removes the sole use of the github.com/MatusOllah/ slogcolor dependency; the edge worker now logs via the standard library slog text handler, preserving log levels including the custom TRACE level. The lang-SDK Go example module, which resolves the SDK via a replace directive, is re-tidied to drop the now-unused indirect slogcolor entry.
jason810496
requested review from
amoghrajesh,
ashb,
gopidesupavan and
potiuk
as code owners
July 31, 2026 11:32
potiuk
approved these changes
Jul 31, 2026
amoghrajesh
approved these changes
Jul 31, 2026
The K8S Lang-SDK test always builds the Go bundle from upstream main's
go-sdk, while go_example is a branch fixture whose go.sum is tidied against
the in-repo go-sdk. When a branch changes go-sdk's dependency graph the two
go-sdks diverge, and Go refuses to build the bundle on the resulting go.sum
drift ("missing go.sum entry ..."), turning the bundle-build step red on the
pull request. Re-tidy the scratch go_example against the go-sdk it is actually
compiled against before packing so the build reconciles the drift itself; the
committed go.sum is left untouched and stays guarded by the
check-go-example-mod-tidy prek hook.
jason810496
requested review from
bugraoz93,
choo121600,
ephraimbuddy,
jedcunningham,
jscheffl and
vatsrahul1001
as code owners
July 31, 2026 15:16
Contributor
|
Hi maintainer, this PR was merged without a milestone set.
|
Contributor
Backport failed to create: v3-3-test. View the failure log Run detailsNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
You can attempt to backport this manually by running: cherry_picker 802ffa7 v3-3-testThis should apply the commit to the v3-3-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
potiuk
pushed a commit
that referenced
this pull request
Aug 1, 2026
…#70908) * Drop colored logging from the Go SDK edge worker The Go SDK edge worker was the only Edge Worker that colorized its console logs. The Python Edge Worker (edge3 provider) does not support colored logging, so the Go side aligns with it and drops the feature rather than maintaining coloring the rest of the Edge Worker surface does not offer. Dropping colored logging removes the sole use of the github.com/MatusOllah/ slogcolor dependency; the edge worker now logs via the standard library slog text handler, preserving log levels including the custom TRACE level. The lang-SDK Go example module, which resolves the SDK via a replace directive, is re-tidied to drop the now-unused indirect slogcolor entry. * Reconcile lang-SDK Go example go.sum before building the bundle The K8S Lang-SDK test always builds the Go bundle from upstream main's go-sdk, while go_example is a branch fixture whose go.sum is tidied against the in-repo go-sdk. When a branch changes go-sdk's dependency graph the two go-sdks diverge, and Go refuses to build the bundle on the resulting go.sum drift ("missing go.sum entry ..."), turning the bundle-build step red on the pull request. Re-tidy the scratch go_example against the go-sdk it is actually compiled against before packing so the build reconciles the drift itself; the committed go.sum is left untouched and stays guarded by the check-go-example-mod-tidy prek hook. (cherry picked from commit 802ffa7)
This was referenced Aug 1, 2026
1 task
potiuk
added a commit
that referenced
this pull request
Aug 1, 2026
The K8S Lang-SDK job fails on every commit here: the bundle is packed against upstream main's go-sdk, but go_example's committed go.sum was tidied against this branch's go-sdk, and the two dependency graphs have diverged. Go refuses to build on that drift. The cherry-pick of #70824 landed without the re-tidy step and its tests, so main builds cleanly and this branch does not.
vatsrahul1001
pushed a commit
that referenced
this pull request
Aug 5, 2026
…#70908) * Drop colored logging from the Go SDK edge worker The Go SDK edge worker was the only Edge Worker that colorized its console logs. The Python Edge Worker (edge3 provider) does not support colored logging, so the Go side aligns with it and drops the feature rather than maintaining coloring the rest of the Edge Worker surface does not offer. Dropping colored logging removes the sole use of the github.com/MatusOllah/ slogcolor dependency; the edge worker now logs via the standard library slog text handler, preserving log levels including the custom TRACE level. The lang-SDK Go example module, which resolves the SDK via a replace directive, is re-tidied to drop the now-unused indirect slogcolor entry. * Reconcile lang-SDK Go example go.sum before building the bundle The K8S Lang-SDK test always builds the Go bundle from upstream main's go-sdk, while go_example is a branch fixture whose go.sum is tidied against the in-repo go-sdk. When a branch changes go-sdk's dependency graph the two go-sdks diverge, and Go refuses to build the bundle on the resulting go.sum drift ("missing go.sum entry ..."), turning the bundle-build step red on the pull request. Re-tidy the scratch go_example against the go-sdk it is actually compiled against before packing so the build reconciles the drift itself; the committed go.sum is left untouched and stays guarded by the check-go-example-mod-tidy prek hook. (cherry picked from commit 802ffa7)
vatsrahul1001
pushed a commit
that referenced
this pull request
Aug 5, 2026
The K8S Lang-SDK job fails on every commit here: the bundle is packed against upstream main's go-sdk, but go_example's committed go.sum was tidied against this branch's go-sdk, and the two dependency graphs have diverged. Go refuses to build on that drift. The cherry-pick of #70824 landed without the re-tidy step and its tests, so main builds cleanly and this branch does not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Go SDK edge worker was the only Edge Worker that colorized its console logs. The Python Edge Worker (
edge3provider) does not support colored logging, so we align the Go side with it and drop the feature rather than maintain coloring the rest of the Edge Worker surface does not offer.What
Edge worker logs change from colored, human-formatted lines to standard
slogtext output (time=... level=INFO msg="..." key=value).Was generative AI tooling used to co-author this PR?