[v3-3-test] Add has_note key to the Grid Runs API response (#69121) - #70834
Merged
Conversation
* Added has_note attribute to get_grid_runs() response * Added tests for has_note * Added note gradient to Bar.tsx to render saved note indicator for a dag run * Modified NOTE_GRADIENT to render constant size note indicator * modified note gradient comment in constants.ts * Added null check for DagRun note content * Added saved note content check for TaskInstanceNote subq * Added has_note to makeRun in useGridPagination.test.ts (cherry picked from commit 6627054)
vatsrahul1001
requested review from
bugraoz93,
choo121600,
ephraimbuddy,
guan404ming,
henry3260,
jason810496,
pierrejeambrun,
rawwar,
ryanahamilton and
shubhamraj-git
as code owners
July 31, 2026 14:06
boring-cyborg
Bot
added
area:API
pierrejeambrun
approved these changes
Jul 31, 2026
vatsrahul1001
added a commit
that referenced
this pull request
Aug 5, 2026
* Added has_note attribute to get_grid_runs() response * Added tests for has_note * Added note gradient to Bar.tsx to render saved note indicator for a dag run * Modified NOTE_GRADIENT to render constant size note indicator * modified note gradient comment in constants.ts * Added null check for DagRun note content * Added saved note content check for TaskInstanceNote subq * Added has_note to makeRun in useGridPagination.test.ts (cherry picked from commit 6627054) Co-authored-by: Jayachandra Kasarla <jayachandra.kasarla@astronomer.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #69121 to
v3-3-test(follows #70829 / #68979, which added the companionhas_noteplumbing).One conflict in
grid.py: onv3-3-testthe Grid-runs query executes with.all(), whereas #69121's context expected.unique().all()(the.unique()comes from an unrelated main-only commit that isn't being backported). Resolved by keeping v3-3-test's.all()and adopting #69121's 3-tuple unpacking ([run for run, _, _ in results]) — the query now selectshas_noteas a third column, so all unpack sites use the 3-tuple consistently. All other hunks applied cleanly.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines — cherry-pick backport with one manual conflict resolution (documented above).