Add `has_note` key to the Grid Runs API response by jayachandrakasarla · Pull Request #69121 · apache/airflow

jayachandrakasarla · 2026-06-29T10:59:59Z

This is a follow up pull request for #68979

Added has_note key to get_grid_runs() response. Here's the screenshot of the response object:

jayachandrakasarla · 2026-06-29T11:31:13Z

@pierrejeambrun raised this PR as we discussed about it here, please review it and let me know if I need to make any changes. Thanks!

pierrejeambrun

Looks good thanks.

Can you do the small UI tweak necessary so we can see the gradient as well on the dag run bar in the grid, in here similarly. (top right corner of the vertical bar representing the dag run should show a similar color gradient)

jayachandrakasarla · 2026-06-30T14:46:06Z

@pierrejeambrun done, this is how it looks now. Please let me know if I should adjust the size of the gradient.

jayachandrakasarla · 2026-07-02T14:13:29Z

@pierrejeambrun could you please review this PR?

pierrejeambrun

Small glitch, depending on the run height, the gradient isn't really visible:

Also one small comment bellow before we can merge.

jayachandrakasarla · 2026-07-03T08:57:56Z

@pierrejeambrun changed NOTE_GRADIENT to use pixels instead of percentage and moved it constants.ts. This is how it looks now:

jayachandrakasarla · 2026-07-06T06:55:16Z

@pierrejeambrun could you please review this? I've made the required changes. Thanks!

aaron-y-chen

Nice PR!

henry3260 · 2026-07-09T14:18:49Z

Rebase to trigger CI

henry3260

Overall LGTM

If I understand right, we should add has_note in

airflow/airflow-core/src/airflow/ui/src/layouts/Details/Grid/useGridPagination.test.ts

Lines 26 to 37 in 2fb2321

    
           const makeRun = (runId: string): GridRunsResponse => ({ 
        
             dag_id: "my_dag", 
        
             duration: 0, 
        
             end_date: null, 
        
             has_missed_deadline: false, 
        
             queued_at: null, 
        
             run_after: "2024-01-01T00:00:00Z", 
        
             run_id: runId, 
        
             run_type: "manual", 
        
             start_date: null, 
        
             state: "success", 
        
           });

pierrejeambrun

LGTM thanks. Tested and working as expected.

pierrejeambrun

I meant to approve

henry3260 · 2026-07-09T15:00:46Z

Not sure why the "Approve and run" button disappeared 🤔

…ag run

bbovenzi · 2026-07-09T15:59:28Z

We have some linting errors. pnpm lint --fix && pnpm format should help

jayachandrakasarla · 2026-07-09T16:17:02Z

We have some linting errors. pnpm lint --fix && pnpm format should help

It was because of missing has_note attribute in makeRun function in useGridPagination.test.ts. I've added and pushed it.

* Added has_note attribute to get_grid_runs() response * Added tests for has_note * Added note gradient to Bar.tsx to render saved note indicator for a dag run * Modified NOTE_GRADIENT to render constant size note indicator * modified note gradient comment in constants.ts * Added null check for DagRun note content * Added saved note content check for TaskInstanceNote subq * Added has_note to makeRun in useGridPagination.test.ts (cherry picked from commit 6627054) Co-authored-by: Jayachandra Kasarla <jayachandra.kasarla@astronomer.io>

jayachandrakasarla requested review from bbovenzi, bugraoz93, choo121600, ephraimbuddy, guan404ming, jason810496, pierrejeambrun, rawwar, ryanahamilton, shubhamraj-git and vatsrahul1001 as code owners June 29, 2026 11:00

boring-cyborg Bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Jun 29, 2026

jayachandrakasarla mentioned this pull request Jun 29, 2026

Reintroduce visual indicator of a note on a Dag-run/ Task-instance #68615

Closed

2 tasks

jayachandrakasarla force-pushed the add-has-note-key-to-grid-runs branch from 02ba41a to 1b75ed4 Compare June 29, 2026 11:25

pierrejeambrun reviewed Jun 30, 2026

View reviewed changes

potiuk requested a review from henry3260 as a code owner July 2, 2026 15:38

pierrejeambrun reviewed Jul 2, 2026

View reviewed changes

Comment thread airflow-core/src/airflow/ui/src/layouts/Details/Grid/Bar.tsx Outdated

aaron-y-chen reviewed Jul 7, 2026

View reviewed changes

Comment thread airflow-core/src/airflow/api_fastapi/core_api/routes/ui/grid.py Outdated

henry3260 force-pushed the add-has-note-key-to-grid-runs branch from 11945f0 to 547fcd6 Compare July 9, 2026 14:18

henry3260 approved these changes Jul 9, 2026

View reviewed changes

pierrejeambrun reviewed Jul 9, 2026

View reviewed changes

pierrejeambrun approved these changes Jul 9, 2026

View reviewed changes

pierrejeambrun reviewed Jul 9, 2026

View reviewed changes

Comment thread airflow-core/src/airflow/api_fastapi/core_api/routes/ui/grid.py

jayachandrakasarla added 7 commits July 9, 2026 23:01

Added has_note attribute to get_grid_runs() response

e9d4b0b

Added tests for has_note

b2ce874

Added note gradient to Bar.tsx to render saved note indicator for a d…

5b31415

…ag run

Modified NOTE_GRADIENT to render constant size note indicator

5c0c38c

modified note gradient comment in constants.ts

96ce85f

Added null check for DagRun note content

3aa2f4f

Added saved note content check for TaskInstanceNote subq

75b73fa

henry3260 force-pushed the add-has-note-key-to-grid-runs branch from 689ada8 to 75b73fa Compare July 9, 2026 15:01

Added has_note to makeRun in useGridPagination.test.ts

709150e

bbovenzi added this to the Airflow 3.3.1 milestone Jul 9, 2026

bbovenzi approved these changes Jul 9, 2026

View reviewed changes

bbovenzi merged commit 6627054 into apache:main Jul 9, 2026
2 checks passed

jayachandrakasarla deleted the add-has-note-key-to-grid-runs branch July 10, 2026 01:36

vatsrahul1001 modified the milestones: Airflow 3.3.1, Airflow 3.4.0 Jul 31, 2026

pierrejeambrun modified the milestones: Airflow 3.4.0, Airflow 3.3.1 Jul 31, 2026

vatsrahul1001 mentioned this pull request Jul 31, 2026

[v3-3-test] Add has_note key to the Grid Runs API response (#69121) #70834

Merged

1 task

vatsrahul1001 mentioned this pull request Aug 7, 2026

Status of testing of Apache Airflow 3.3.1rc2 #71274

Closed

	const makeRun = (runId: string): GridRunsResponse => ({
	dag_id: "my_dag",
	duration: 0,
	end_date: null,
	has_missed_deadline: false,
	queued_at: null,
	run_after: "2024-01-01T00:00:00Z",
	run_id: runId,
	run_type: "manual",
	start_date: null,
	state: "success",
	});

Uh oh!

Conversation

jayachandrakasarla commented Jun 29, 2026

Uh oh!

jayachandrakasarla commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pierrejeambrun left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jayachandrakasarla commented Jun 30, 2026

Uh oh!

jayachandrakasarla commented Jul 2, 2026

Uh oh!

pierrejeambrun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jayachandrakasarla commented Jul 3, 2026

Uh oh!

jayachandrakasarla commented Jul 6, 2026

Uh oh!

aaron-y-chen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

henry3260 commented Jul 9, 2026

Uh oh!

henry3260 left a comment

Choose a reason for hiding this comment

Uh oh!

pierrejeambrun left a comment

Choose a reason for hiding this comment

Uh oh!

pierrejeambrun left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

henry3260 commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bbovenzi commented Jul 9, 2026

Uh oh!

jayachandrakasarla commented Jul 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jayachandrakasarla commented Jun 29, 2026 •

edited

Loading

pierrejeambrun left a comment •

edited

Loading

pierrejeambrun left a comment •

edited

Loading

henry3260 commented Jul 9, 2026 •

edited

Loading