[v3-3-test] UI: Move JSON validation and prettifying into JsonEditor (#70380) - #70554
Merged
Conversation
…70380) The validate-and-prettify logic for JSON input lived in CreateAssetEventModal with a TODO asking to move it into the shared JsonEditor. It now lives behind new optional prettify/onError props so any JSON input in the UI can opt in instead of re-implementing it. (cherry picked from commit f5e3c1e) Co-authored-by: Yang <773542570@qq.com>
1 task
potiuk
marked this pull request as ready for review
July 28, 2026 14:23
potiuk
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
July 28, 2026 14:23
bbovenzi
approved these changes
Jul 28, 2026
Contributor
Author
|
Hi maintainer, this PR was merged without a milestone set.
|
vatsrahul1001
pushed a commit
that referenced
this pull request
Aug 5, 2026
…70380) (#70554) The validate-and-prettify logic for JSON input lived in CreateAssetEventModal with a TODO asking to move it into the shared JsonEditor. It now lives behind new optional prettify/onError props so any JSON input in the UI can opt in instead of re-implementing it. (cherry picked from commit f5e3c1e) Co-authored-by: Yang <773542570@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The validate-and-prettify logic for JSON input lived in
CreateAssetEventModal with a TODO asking to move it into the shared
JsonEditor. It now lives behind new optional prettify/onError props so
any JSON input in the UI can opt in instead of re-implementing it.
(cherry picked from commit f5e3c1e)
Co-authored-by: Yang 773542570@qq.com