Skip to content

UI: Move JSON validation and prettifying into JsonEditor - #70380

Merged
bbovenzi merged 1 commit into
apache:mainfrom
ABiscuitttt:ui-json-editor-prettify
Jul 27, 2026
Merged

UI: Move JSON validation and prettifying into JsonEditor#70380
bbovenzi merged 1 commit into
apache:mainfrom
ABiscuitttt:ui-json-editor-prettify

Conversation

@ABiscuitttt

@ABiscuitttt ABiscuitttt commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

The validate-and-prettify logic for JSON input lived in CreateAssetEventModal with a TODO asking to move it into the shared JsonEditor. It now lives behind new optional prettify/onError props so any JSON input in the UI can opt in instead of re-implementing it.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label Jul 24, 2026
@boring-cyborg

boring-cyborg Bot commented Jul 24, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@ABiscuitttt
ABiscuitttt force-pushed the ui-json-editor-prettify branch 3 times, most recently from 1eff6bd to 9ec1b76 Compare July 27, 2026 07:57
The validate-and-prettify logic for JSON input lived in
CreateAssetEventModal with a TODO asking to move it into the shared
JsonEditor. It now lives behind new optional prettify/onError props so
any JSON input in the UI can opt in instead of re-implementing it.
@ABiscuitttt
ABiscuitttt force-pushed the ui-json-editor-prettify branch from 9ec1b76 to f7dbd30 Compare July 27, 2026 08:55
@bbovenzi bbovenzi added this to the Airflow 3.3.1 milestone Jul 27, 2026
@bbovenzi bbovenzi added the backport-to-v3-3-test Backport to v3-3-test label Jul 27, 2026
@bbovenzi
bbovenzi merged commit f5e3c1e into apache:main Jul 27, 2026
89 checks passed
@boring-cyborg

boring-cyborg Bot commented Jul 27, 2026

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-3-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
v3-3-test PR Link

@ABiscuitttt
ABiscuitttt deleted the ui-json-editor-prettify branch July 28, 2026 01:39
potiuk pushed a commit that referenced this pull request Jul 28, 2026
…70380) (#70554)

The validate-and-prettify logic for JSON input lived in
CreateAssetEventModal with a TODO asking to move it into the shared
JsonEditor. It now lives behind new optional prettify/onError props so
any JSON input in the UI can opt in instead of re-implementing it.
(cherry picked from commit f5e3c1e)

Co-authored-by: Yang <773542570@qq.com>
vatsrahul1001 pushed a commit that referenced this pull request Aug 5, 2026
…70380) (#70554)

The validate-and-prettify logic for JSON input lived in
CreateAssetEventModal with a TODO asking to move it into the shared
JsonEditor. It now lives behind new optional prettify/onError props so
any JSON input in the UI can opt in instead of re-implementing it.
(cherry picked from commit f5e3c1e)

Co-authored-by: Yang <773542570@qq.com>
dabla pushed a commit to dabla/airflow that referenced this pull request Aug 14, 2026
The validate-and-prettify logic for JSON input lived in
CreateAssetEventModal with a TODO asking to move it into the shared
JsonEditor. It now lives behind new optional prettify/onError props so
any JSON input in the UI can opt in instead of re-implementing it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-3-test Backport to v3-3-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants