UI: Move JSON validation and prettifying into JsonEditor - #70380
Merged
Conversation
ABiscuitttt
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
July 24, 2026 11:53
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
ABiscuitttt
force-pushed
the
ui-json-editor-prettify
branch
3 times, most recently
from
July 27, 2026 07:57
1eff6bd to
9ec1b76
Compare
The validate-and-prettify logic for JSON input lived in CreateAssetEventModal with a TODO asking to move it into the shared JsonEditor. It now lives behind new optional prettify/onError props so any JSON input in the UI can opt in instead of re-implementing it.
ABiscuitttt
force-pushed
the
ui-json-editor-prettify
branch
from
July 27, 2026 08:55
9ec1b76 to
f7dbd30
Compare
bbovenzi
approved these changes
Jul 27, 2026
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Contributor
Backport successfully created: v3-3-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
potiuk
pushed a commit
that referenced
this pull request
Jul 28, 2026
…70380) (#70554) The validate-and-prettify logic for JSON input lived in CreateAssetEventModal with a TODO asking to move it into the shared JsonEditor. It now lives behind new optional prettify/onError props so any JSON input in the UI can opt in instead of re-implementing it. (cherry picked from commit f5e3c1e) Co-authored-by: Yang <773542570@qq.com>
vatsrahul1001
pushed a commit
that referenced
this pull request
Aug 5, 2026
…70380) (#70554) The validate-and-prettify logic for JSON input lived in CreateAssetEventModal with a TODO asking to move it into the shared JsonEditor. It now lives behind new optional prettify/onError props so any JSON input in the UI can opt in instead of re-implementing it. (cherry picked from commit f5e3c1e) Co-authored-by: Yang <773542570@qq.com>
dabla
pushed a commit
to dabla/airflow
that referenced
this pull request
Aug 14, 2026
The validate-and-prettify logic for JSON input lived in CreateAssetEventModal with a TODO asking to move it into the shared JsonEditor. It now lives behind new optional prettify/onError props so any JSON input in the UI can opt in instead of re-implementing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The validate-and-prettify logic for JSON input lived in CreateAssetEventModal with a TODO asking to move it into the shared JsonEditor. It now lives behind new optional prettify/onError props so any JSON input in the UI can opt in instead of re-implementing it.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.