Skip to content

Handle ValueError for trigger_dag_run API request #67601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaxil merged 1 commit into from
Jul 30, 2026
Merged

Handle ValueError for trigger_dag_run API request #67601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions airflow-core/src/airflow/api_fastapi/execution_api/routes/dag_runs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,14 @@ def trigger_dag_run(
status.HTTP_400_BAD_REQUEST,
detail={"reason": "invalid_partition_key", "message": str(e)},
) from e
except ValueError as e:
Comment thread
potiuk marked this conversation as resolved.
raise HTTPException(
status.HTTP_400_BAD_REQUEST,
detail={
"reason": "value_error",
"message": str(e),
},
) from e


@router.post(
Expand Down
26 changes: 26 additions & 0 deletions airflow-core/tests/unit/api_fastapi/execution_api/versions/head/test_dag_runs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

from __future__ import annotations

import re
from unittest import mock

import pytest
Expand Down Expand Up @@ -322,6 +323,31 @@ async def auth_as_parent_ti(request: Request) -> TIToken:
child_run = session.scalars(select(DagRun).where(DagRun.run_id == child_run_id)).one()
assert child_run.triggering_user_name == parent_triggering_user_name

def test_trigger_dag_run_value_error(self, client, session, dag_maker):
"""Test that error is raised when a DAG Run has ValueError."""

dag_id = "test_trigger_dag_run_value_error"
run_id = "manual__{test_run_id}"
logical_date = timezone.datetime(2026, 5, 22)

with dag_maker(dag_id=dag_id, session=session, serialized=True):
EmptyOperator(task_id="test_task")

session.commit()

response = client.post(
f"/execution/dag-runs/{dag_id}/{run_id}",
json={"logical_date": logical_date.isoformat()},
)

detail_message = response.json()["detail"]["message"]
detail_reason = response.json()["detail"]["reason"]

pattern = r"The run_id provided '.*' does not match regex pattern '.*' or '.*'"
assert re.search(pattern, detail_message)
assert detail_reason == "value_error"
assert response.status_code == 400


class TestDagRunClear:
def setup_method(self):
Expand Down
Loading