Handle ValueError for trigger_dag_run API request - #67601
Conversation
SameerMesiah97
left a comment
There was a problem hiding this comment.
I think the rationale could be better explained. ValueError is far too broad in this codepath and catching it can make real issues under a generic 400 exception.
|
@MaksYermak A few things need addressing before review — see our Pull Request quality criteria.
No rush. Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you. |
|
@MaksYermak Converting to draft — this PR does not yet meet our Pull Request quality criteria.
See the linked criteria for how to fix each item, then mark the PR "Ready for review". This is not a rejection — just an invitation to bring the PR up to standard. No rush. Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you. |
7495da6 to
6d59d27
Compare
6d59d27 to
9fc06e6
Compare
|
@potiuk hi there! can we please review these changes and check if they can be merged? thanks! |
|
Hi maintainer, this PR was merged without a milestone set.
|
Backport successfully created: v3-3-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
In this PR I have added a code which handle
ValueErrorexception fortrigger_dag_runAPI request and raiseHTTPExceptionwith400http code. These changes improve error messaging from this request and user can see clear message in task logs.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.