Skip to content

Properly pass codecov-token to composite action - #40138

Merged
potiuk merged 1 commit into
apache:mainfrom
potiuk:fix-codecov-token-passed-as-input
Jun 8, 2024
Merged

Properly pass codecov-token to composite action#40138
potiuk merged 1 commit into
apache:mainfrom
potiuk:fix-codecov-token-passed-as-input

Conversation

@potiuk

@potiuk potiuk commented Jun 8, 2024

Copy link
Copy Markdown
Member

Turns out that in order to pass secret to a composite action you need to pass it as input.

Further follow up on #40136 and #40128


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Turns out that in order to pass secret to a composite action you
need to pass it as input.

Further follow up on apache#40136 and apache#40128
@potiuk
potiuk merged commit 3c8cd1c into apache:main Jun 8, 2024
@potiuk
potiuk deleted the fix-codecov-token-passed-as-input branch June 8, 2024 12:18
@potiuk

potiuk commented Jun 8, 2024

Copy link
Copy Markdown
Member Author

Merging. We will not see if it works until it's merged :)

romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
Turns out that in order to pass secret to a composite action you
need to pass it as input.

Further follow up on apache#40136 and apache#40128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants