Skip to content

Add Codecov token - #40136

Merged
potiuk merged 1 commit into
apache:mainfrom
potiuk:add-codecov-token
Jun 8, 2024
Merged

Add Codecov token#40136
potiuk merged 1 commit into
apache:mainfrom
potiuk:add-codecov-token

Conversation

@potiuk

@potiuk potiuk commented Jun 8, 2024

Copy link
Copy Markdown
Member

Codecov4 requires to use upload token for all runs running directly from the repository (the exceptions are Pull Requests from forks to public repositories). I generated upload token and configured it as a secret, so now what we need is to enable it during the upload.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Codecov4 requires to use upload token for all runs running directly
from the repository (the exceptions are Pull Requests from forks
to public repositories). I generated upload token and configured it
as a secret, so now what we need is to enable it during the upload.
@potiuk

potiuk commented Jun 8, 2024

Copy link
Copy Markdown
Member Author

Follow up after #40128

@potiuk
potiuk requested review from hussein-awala and kaxil June 8, 2024 10:31
@potiuk
potiuk merged commit 663d422 into apache:main Jun 8, 2024
@potiuk
potiuk deleted the add-codecov-token branch June 8, 2024 10:33
@Taragolis

Copy link
Copy Markdown
Contributor

Nice. I have a hectic weeks, I've also have a plan to do the same but wait until their upload become more stable. But it is really nice to bump to v4 (which unfortunately required to have a token)

potiuk added a commit to potiuk/airflow that referenced this pull request Jun 8, 2024
Turns out that in order to pass secret to a composite action you
need to pass it as input.

Further follow up on apache#40136 and apache#40128
potiuk added a commit that referenced this pull request Jun 8, 2024
Turns out that in order to pass secret to a composite action you
need to pass it as input.

Further follow up on #40136 and #40128
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
Codecov4 requires to use upload token for all runs running directly
from the repository (the exceptions are Pull Requests from forks
to public repositories). I generated upload token and configured it
as a secret, so now what we need is to enable it during the upload.
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
Turns out that in order to pass secret to a composite action you
need to pass it as input.

Further follow up on apache#40136 and apache#40128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants