Skip to content

Run Trigger Page: Configurable number of recent configs #36878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jscheffl merged 2 commits into from
Jan 20, 2024
Merged

Run Trigger Page: Configurable number of recent configs #36878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d17342
Run Trigger Page: Configurable number of recent configs
AchimGaedkeLynker Jan 18, 2024
2cc5ae6
no abbreviations in configuration names
AchimGaedkeLynker Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions airflow/config_templates/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1875,6 +1875,13 @@ webserver:
type: boolean
example: ~
default: "False"
num_recent_configurations_for_trigger:
description: |
Number of recent DAG run configurations in the selector on the trigger web form.
version_added: 2.9.0
type: integer
example: "10"
default: "5"
allow_raw_html_descriptions:
description: |
A DAG author is able to provide any raw HTML into ``doc_md`` or params description in
Expand Down
3 changes: 2 additions & 1 deletion airflow/www/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2029,6 +2029,7 @@ def trigger(self, dag_id: str, session: Session = NEW_SESSION):
flash(f"Cannot create dagruns because the dag {dag_id} has import errors", "error")
return redirect(origin)

num_recent_confs = conf.getint("webserver", "num_recent_configurations_for_trigger")
recent_runs = session.execute(
select(DagRun.conf, func.max(DagRun.run_id).label("run_id"), func.max(DagRun.execution_date))
.where(
Expand All @@ -2038,7 +2039,7 @@ def trigger(self, dag_id: str, session: Session = NEW_SESSION):
)
.group_by(DagRun.conf)
.order_by(func.max(DagRun.execution_date).desc())
.limit(5)
.limit(num_recent_confs)
)
recent_confs = {
run_id: json.dumps(run_conf)
Expand Down