Run Trigger Page: Configurable number of recent configs - #36878
Conversation
e7a3221 to
7d17342
Compare
0b278a3 to
2cc5ae6
Compare
dirrao
left a comment
There was a problem hiding this comment.
It would be great if you can add the test cases for this new change. If existing test cases are not available due to feasibility, then I would like to hear from others.
Can you attach the screenshot for the affected form/page?
|
I'd be really happy getting advice on unit tests, figuring out the test/CI setup for each project is always daunting. This PR seems to have a decent example for unit-testing configurations. - @dirrao , what's your take? |
jscheffl
left a comment
There was a problem hiding this comment.
Without major rework of the overall code in the views it is hard to add tests - also other options with parameters are not explicitly tested. Also other parameters like show_trigger_form_if_no_params are not tested.
I assume it is good like this.
As it is a new feature and not a bug I'd not merge it into a patch release - but 2.9.0 is good as well.
THANKS for the contribution!

Some users are heavily relying on running DAGs manually by altering or repeating previous configurations.
The number (more precisely limit) of previous runs sent to the
trigger.htmlselector is 5 and quite low for this use-case.This PR makes the number of recent DAG run configurations configurable.
Questions:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.