Skip to content

Make cncf.kubernetes required for flink provider - #29710

Merged
eladkal merged 1 commit into
apache:mainfrom
potiuk:make-cncf-kubernetes-required-for-flink
Feb 23, 2023
Merged

Make cncf.kubernetes required for flink provider#29710
eladkal merged 1 commit into
apache:mainfrom
potiuk:make-cncf-kubernetes-required-for-flink

Conversation

@potiuk

@potiuk potiuk commented Feb 22, 2023

Copy link
Copy Markdown
Member

The #29707 added version to optional cncf.kubernetes dependency, but in fact the kubernetes provider is a required dependency so we need to change it to be so.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

The apache#29707 added version to optional cncf.kubernetes dependency, but
in fact the kubernetes provider is a required dependency so we need
to change it to be so.
@potiuk

potiuk commented Feb 22, 2023

Copy link
Copy Markdown
Member Author

Actually @xinbinhuang - this one is "proper" as it turned out after discussion in #29691 (reply in thread)

@xinbinhuang

Copy link
Copy Markdown
Contributor

Actually @xinbinhuang - this one is "proper" as it turned out after discussion in #29691 (reply in thread)

thx for fixing this! 👍

@eladkal
eladkal merged commit 68412e1 into apache:main Feb 23, 2023
@potiuk
potiuk deleted the make-cncf-kubernetes-required-for-flink branch March 22, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants