Add more precise optional dependency to cncf.kubernetes from flink - #29707
Merged
potiuk merged 1 commit intoFeb 22, 2023
Merged
Conversation
The Flink provider has an optional cncf.kubernetes depedency that requires cncf.kubernetes at least in version 5.1.0 (some new features of the classes in cncf.kubernetes are used in Flink on Kubernetes.
potiuk
force-pushed
the
add-flink-kubernetes-more-accurate-dependency
branch
from
February 22, 2023 21:15
ff54894 to
43c52be
Compare
xinbinhuang
approved these changes
Feb 22, 2023
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Feb 22, 2023
The apache#29707 added version to optional cncf.kubernetes dependency, but in fact the kubernetes provider is a required dependency so we need to change it to be so.
eladkal
pushed a commit
that referenced
this pull request
Feb 23, 2023
The #29707 added version to optional cncf.kubernetes dependency, but in fact the kubernetes provider is a required dependency so we need to change it to be so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Flink provider has an optional cncf.kubernetes depedency that requires cncf.kubernetes at least in version 5.1.0 (some new features of the classes in cncf.kubernetes are used in Flink on Kubernetes.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.