Skip to content

[AIRFLOW-1422] Customize File Handler for logging module via airflow.cfg #2452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronfung wants to merge 1 commit into from
Closed

[AIRFLOW-1422] Customize File Handler for logging module via airflow.cfg #2452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,3 +124,6 @@ ENV/

# Spark
rat-results.txt

# IDE History
.history
12 changes: 11 additions & 1 deletion airflow/bin/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,17 @@ def sigquit_handler(sig, frame):

def setup_logging(filename):
root = logging.getLogger()
handler = logging.FileHandler(filename)
log_handler_kargs = None
lh_mod_name, lh_cls_name = conf.get('core', 'log_handler_class').rsplit('.', 1)
lh_mod = __import__(lh_mod_name, globals(), locals(), [lh_cls_name], 0)
log_handler = getattr(lh_mod, lh_cls_name)
try:
log_handler_kargs = json.loads(conf.get('core', 'log_handler_params'))
handler = log_handler(filename, **log_handler_kargs)
except ValueError:
handler = log_handler(filename)
logging.info('log_handler: {}'.format(log_handler))
logging.info('log_handler_kargs: {}'.format(log_handler_kargs))
formatter = logging.Formatter(settings.SIMPLE_LOG_FORMAT)
handler.setFormatter(formatter)
root.addHandler(handler)
Expand Down
4 changes: 4 additions & 0 deletions airflow/config_templates/default_airflow.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@ log_format_with_pid = [%%(asctime)s] [%%(process)d] {{%%(filename)s:%%(lineno)d}
log_format_with_thread_name = [%%(asctime)s] {{%%(filename)s:%%(lineno)d}} %%(threadName)s %%(levelname)s - %%(message)s
simple_log_format = %%(asctime)s %%(levelname)s - %%(message)s

# Log Handler (supports TimedRotatingFileHandler, RotatingFileHandler, WatchedFileHandler, FileHandler or StreamHandler)
log_handler_class = logging.FileHandler
log_handler_params = None # valid json format required or ignored.

# The executor class that airflow should use. Choices include
# SequentialExecutor, LocalExecutor, CeleryExecutor, DaskExecutor
executor = SequentialExecutor
Expand Down