You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
# Allow log files generated by the scheduler, webserver and workers be more organized based on time interval, size etc. Make it easier for analysis, maintenance and cleanup.
# Log Handler - it supports all file handlers: TimedRotatingFileHandler, RotatingFileHandler, WatchedFileHandler, FileHandler or StreamHandler.
#Two configuration keys are added: log_handler_class and log_handler_params. Default is using logging.FileHandler with None.
e.g. 1 log_handler_class = logging.handlers.RotatingFileHandler log_handler_params = {"maxBytes":"100000"}
e.g. 2 log_handler_class = logging.handlers.TimedRotatingFileHandler log_handler_params = {"backupCount":7,"interval":1,"when":"d"}
default: log_handler_class = logging.FileHandler log_handler_params = None
Tests
./run_unit_tests.sh python2.7.x and python3.5.x
Commits
My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
@ronfung, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mistercrunch, @bolkedebruin and @aoen to be potential reviewers.
Hi Chris, I agree with @aoen. @allisonwang is working in getting logging properly fixed which will allow you to this within the config more closely to the Python standards. Maybe you would like to chime in and help her/us getting it proper so we can work from there?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Airflow maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
e.g. 1
log_handler_class = logging.handlers.RotatingFileHandlerlog_handler_params = {"maxBytes":"100000"}e.g. 2
log_handler_class = logging.handlers.TimedRotatingFileHandlerlog_handler_params = {"backupCount":7,"interval":1,"when":"d"}default:
log_handler_class = logging.FileHandlerlog_handler_params = NoneTests
Commits