Remove redundant LogEntry value (#3997) - #4071
Merged
Merged
Conversation
Remove the `LogEntry.getValue()` method and use the column qualifier for the file path, without the redundant storage in the Value * Remove `getValue()` method and use empty `new Value()` * Create addToMutation method to remove boilerplate for storing the LogEntry in the metadata * Strictly validate the metadata log entries' column qualifier This re-applies the reverted change for apache#3997, 0cdf6dd, but without the renaming of filePath to logReference, since with further analysis of the schema, it was discovered that these are, in fact, file paths, and not just generic references to log IDs. This re-application also removes the metadata constraint that expected the value to be non-empty, which was overlooked on the first attempt. --------- Co-authored-by: Christopher Tubbs <ctubbsii@apache.org>
EdColeman
reviewed
Dec 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
LogEntry.getValue()method and use the column qualifier for the file path, without the redundant storage in the ValuegetValue()method and use emptynew Value()This re-applies the reverted change for this ticket, 0cdf6dd, but without the renaming of filePath to logReference, since with further analysis of the schema, it was discovered that these are, in fact, file paths, and not just generic references to log IDs.
This re-application also removes the metadata constraint that expected the value to be non-empty, which was overlooked on the first attempt.