Skip to content

Enhancing LogEntry Validation and Upgrading Column Qualifier Format- 3943 ticket - #4057

Closed
rsingh433 wants to merge 13 commits into
apache:mainfrom
rsingh433:Validation3943
Closed

Enhancing LogEntry Validation and Upgrading Column Qualifier Format- 3943 ticket#4057
rsingh433 wants to merge 13 commits into
apache:mainfrom
rsingh433:Validation3943

Conversation

@rsingh433

Copy link
Copy Markdown
Contributor

Updated the code to drop "-/" portion and expect 3 items

@ctubbsii

Copy link
Copy Markdown
Member

It looks like this depends on #3997, so I'll review this after that's done and merged.

@ctubbsii
ctubbsii self-requested a review December 12, 2023 14:58
@rsingh433 rsingh433 changed the title Validation3943 Enhancing LogEntry Validation and Upgrading Column Qualifier Format- 3943 ticket Dec 12, 2023
@ctubbsii ctubbsii linked an issue Dec 12, 2023 that may be closed by this pull request
@ctubbsii

Copy link
Copy Markdown
Member

I resolved the conflicts so this could build, and we could see the differences that this PR introduces more easily, but it looks like it still has some old commits from #3997 that were excluded when that was reverted and redone with #4071 (like keeping the filePath names). So, this PR will have to be rebase'd onto the current main branch and the diffs trimmed down to just the new changes intended to be part of this PR rather than carried over from #3997.

@rsingh433 rsingh433 closed this Dec 14, 2023
@rsingh433
rsingh433 deleted the Validation3943 branch December 14, 2023 17:10
@ctubbsii

Copy link
Copy Markdown
Member

This stricter validation was based on the misunderstanding that the log entry had a fixed number of elements. However, the entry contains a path, which can have an arbitrary number of elements, so I think the current validation is sufficient. It checks the last two path elements for the tserver and uuid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate removing getValue() from LogEntry class

2 participants