test(acp): make shell workdir location assertion windows-safe#32306
Merged
Conversation
Use the platform path resolver as the oracle instead of a hardcoded forward-slash path, matching the resolve() call in tool.ts. The previous assertion failed on the Windows unit-test runner where resolve() yields backslash paths.
davidgut1982
pushed a commit
to davidgut1982/opencode
that referenced
this pull request
Jun 19, 2026
markjaquith
pushed a commit
to markjaquith/opencode
that referenced
this pull request
Jun 23, 2026
BenGu3
pushed a commit
to BenGu3/opencode
that referenced
this pull request
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #32304.
The
toLocationsbash test hardcoded/workspace/subdir, but on the Windows unit-test runnerpath.resolve()produces backslash paths (\workspace\subdir), so the assertion failed there. Use the platform path resolver as the oracle instead — matching theresolve()call intool.tsand the existing convention across the test suite.Source behavior is unchanged; this is test-only.