fix(acp): show shell command in ACP tool calls#32304
Merged
Merged
Conversation
ACP clients showed the bash tool's description but not the command being run, so you couldn't see what you were approving. Use the command as the tool-call title and populate rawInput/locations with the command and resolved working directory, while keeping kind "execute". Fixes #10998. Co-authored-by: Mert Can Demir <validatedev@gmail.com>
Contributor
|
@nexxeln thank you, and thanks for having me as a co author! |
3 tasks
davidgut1982
pushed a commit
to davidgut1982/opencode
that referenced
this pull request
Jun 19, 2026
Co-authored-by: Mert Can Demir <validatedev@gmail.com>
markjaquith
pushed a commit
to markjaquith/opencode
that referenced
this pull request
Jun 23, 2026
Co-authored-by: Mert Can Demir <validatedev@gmail.com>
BenGu3
pushed a commit
to BenGu3/opencode
that referenced
this pull request
Jun 27, 2026
Co-authored-by: Mert Can Demir <validatedev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10998.
ACP clients (e.g. Zed) showed the bash tool's description but not the actual command, so you couldn't see what you were approving. We now set the tool-call title to the command itself and populate
rawInput/locationswith the command and resolved working directory — while keepingkind: "execute"so Zed keeps its native "Run Command" box.Credit to @validatedev for the original investigation in #11303 (co-authored).