feat: migrate Home and Setup pages to the design system - #80
Merged
Merged
Conversation
- Add AppFoundationPageTitle: wraps the design system's AppPageTitle and appends the configured BrandName as the document-title suffix, so pages no longer hardcode a brand and set the topbar breadcrumb. - Home (/dashboard): use AppFoundationPageTitle with a Dashboard breadcrumb, mute the description text, and drop the hardcoded brand from the copy. - Sample Home (/): set a Home breadcrumb. - Setup: switch the form from horizontal label rows to the stacked design login style (labels above full-width fields), use ag-login-actions, sentence-case the heading/title, and use a neutral email placeholder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second slice of the design-system adoption — the first page migrations (Home + Setup). Follows the infra/shell PR (#79).
Changes
AppFoundationPageTitle(RCLComponents/Shared): wraps the design system'sAppPageTitleand appends the configuredBrandName(fromAppFoundationLayoutOptions) as the document-title suffix — so pages stop hardcoding a brand and get a topbar breadcrumb. Mirrors the identity package'sIdentityPageTitle./dashboard):AppFoundationPageTitlewith aDashboardbreadcrumb, muted description text, and the hardcodednerdventures.blogcopy removed./): sets aHomebreadcrumb.LoginLayout): form switched from horizontal label rows to the stacked design login style (labels above full-width fields),login-action-row→ag-login-actions, sentence-cased heading/title, neutral email placeholder.Verification
dotnet build: 0 errors ·dotnet csharpier check .: passes · unit tests: 56/56main.Notes
nerdventures.bloglived in both the title and body copy — both now go throughBrandName/ neutral wording.Brandslot; empty breadcrumb on not-yet-migrated pages).Next
Administration pages (
EmailSettings,LoginFeatures) — forms/tables that benefit most from the design conventions.