Repository navigation
Conversation
This was referenced Oct 11, 2026
Owner
Author
|
Consolidated into #30 at the same accepted final source tree (b66e06e), now targeting feature/connection-resource-access. Closing this individual stack PR as superseded; its commits, review record and branch remain preserved. No feature activation or main/upstream merge. Tracking issues remain open until integration verification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
External PR reads could touch persisted storage or publish held values after current authority changed during an await. External summary/stack reads now use Effect Cache with the existing TTL and service epochs, isolated by authority and action scope. Trusted reads retain disk persistence and restart reuse.
Revision invalidation preserves typed denial without disabling caching. Held diff, summary, detail and stats continuations recheck before publication/delivery. Existing write scopes and invoking refresh authority remain intact.
Stack base:
access/04c3-pr-read-effectsat exact acceptedc14c83d5ce70dc6165d715ce255c42c8764c6b29; PR27 remains OPEN/unmerged. Only approved 04c3b2. Final PR write effects04c4 and05–14 remain deferred; ResourceGrantGuard stays CLOSED.Refs #5, #1.
Evidence
After: 65 focused tests pass: 21 cache/storage cuts and controls, 44 service cache/refresh/scope controls. Final typed-fixture changes also pass their 14 affected tests.
./node_modules/.bin/vp run --filter t3 typecheck, five-file lint/format and diff checks pass. Unselected tests use CLI name filters; no committed skips, full-repo checks or CI watching.Merge Danger
Door: Two-way. Existing disk format and contracts unchanged.
Blast Radius: Bounded. PR read caches, refreshes and held values; external reads rebuild memory after restart. Source acceptance and integration remain coordinator work.
Model: gpt-6.1-sol. Harness: Codex.