Skip to content

fix(server): admit pull request reads at service boundaries - #26

Closed
alimek wants to merge 2 commits into
access/04c2-worktree-mutationsfrom
access/04c3-pr-reads-routing
Closed

alimek wants to merge 2 commits into
access/04c2-worktree-mutationsfrom
access/04c3-pr-reads-routing

Conversation

@alimek

@alimek alimek commented Oct 11, 2026 •

Copy link
Copy Markdown
Owner

Summary

Pull request calls could reach enriched project shells, host routing, credentials or cached data without current resource admission. All34 existing service entry points now require live external authority or explicit internal trust; HTTP/WS and linked metadata use shared admitted service seams.

PR service entry
  current scope + raw registered owner
  visible repository routing
  admitted credential/API/cache operation
  current result/stream admission

All11 writes retain source-control:write common entry and existing action permissions. Owner/trusted hosting fallback remains available. Newly reached authorization errors remain typed through provider translation and service fallback.

Evidence

  • Before: optional collection snapshots; unguarded reference/stream methods; enriched shell and broad hosting fallback.
  • After:9 focused service/provider/caller suites,373 tests pass; real SQLite + Deferred owner/routing/cache/metadata cuts and all11 write-only controls. HTTP contract test passes. Named server typecheck and touched-file lint/format/diff pass (six inherited unused lint warnings).

Standards repair

At coordinator-reviewed b4d2dda1efbfac67617c6ac7852a7a06297d9d70, Standards found one P3 recovery convention issue; Spec found zero issues. Normal repair commit 0668bc7a3890c6caaa6292696e026bd39c224c33 replaces only listStats schema-predicate catchIf with whole-channel Effect.catch, explicitly re-failing authorization denial and retaining None for ordinary failures. Existing real SQLite + Deferred owner-cut test now also exercises listStats before credential/cache/API effects.

Six affected stats/admission controls pass. Named server typecheck, two touched files' lint/format and diff checks pass. Prior 373-test implementation evidence and coordinator 202-test review remain historical; neither suite rerun for this narrow repair. Exact repaired source acceptance remains pending.

Merge Danger

Door: two-way. Blast Radius: server.

This is04c3a only.04c3b delayed batch/context, credential/identity/persisted-cache permit guards and complete lower fallback audit remain pending;04c4 final write effects remain pending. Production resource issuance stays CLOSED. No full read-side enforcement or source acceptance claimed. Parent PR25 remains open/unmerged; do not merge/restack this slice.

Refs #5, #1

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Oct 11, 2026
@alimek

alimek commented Oct 11, 2026

Copy link
Copy Markdown
Owner Author

Consolidated into #30 at the same accepted final source tree (b66e06e), now targeting feature/connection-resource-access. Closing this individual stack PR as superseded; its commits, review record and branch remain preserved. No feature activation or main/upstream merge. Tracking issues remain open until integration verification.

@alimek alimek closed this Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant