Pick up the terminal session locale fix - #88
Merged
Conversation
terminal-proxy 0.6.4 defaults LANG to C.UTF-8 for a session whose image names no locale. Without one glibc falls back to C, which cannot decode UTF-8: a typed accent or Cyrillic letter reached zsh's line editor as bytes it could not read and it rendered each as <ffffffff>. Pins only, so the umbrella takes a patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
terminal-proxy
0.6.3→0.6.4, umbrella0.32.0→0.32.1.0.6.4 defaults
LANGtoC.UTF-8for a session whose image names no locale. Without one glibc falls back to C, which cannot decode UTF-8 — a typed accent or Cyrillic letter reached zsh's line editor as bytes it could not read, and it rendered each as<ffffffff>. Typingпривет çin the sandboxes-app terminal produced fourteen of them.Pins only, so the umbrella takes a patch, matching
0.18.1.Verified locally with the same steps CI runs —
helm dependency updateresolves terminal-proxy to 0.6.4 in the lock, andhelm lintpasses.Upstream: agynio/terminal-proxy#9. The devcontainer images now set
ENV LANG=C.UTF-8too (agynio/devcontainer#7, agynio/devcontainer-go#8), which covers the paths that are not terminal sessions.