feat: name a UTF-8 locale - #7
Merged
Merged
Conversation
ubuntu:24.04 names no locale, so glibc falls back to C, which cannot decode UTF-8. Every byte of a typed accent or Cyrillic letter reaches zsh's line editor undecodable and it renders each as <ffffffff> -- typing "привет ç" in a terminal session produced fourteen of them. C.UTF-8 is built into glibc 2.39, so this needs no locales package and no locale-gen. Reproduced and confirmed fixed on ubuntu:24.04 + zsh driven through a pty. terminal-proxy defaults LANG for terminal sessions too, which covers images we do not build; this covers the paths that are not terminal sessions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ubuntu:24.04names no locale, so glibc falls back to C, which cannot decode UTF-8. Every byte of a typed accent or Cyrillic letter reaches zsh's line editor undecodable and it renders each as<ffffffff>— typingпривет çin a sandboxes-app terminal produced fourteen of them.C.UTF-8is built into glibc 2.39, so nolocalespackage and nolocale-gen.Reproduced on
ubuntu:24.04+ zsh through a real pty:agynio/terminal-proxy#9 defaults
LANGfor terminal sessions, which covers images we do not build. This covers the paths that are not terminal sessions — agent processes andEXECsessions.