Skip to content

fix(e2e): align runners lifecycle owner - #217

Merged
rowan-stein merged 6 commits into
mainfrom
noa/fix-go-core-runners-llm-helpers
Jul 17, 2026
Merged

fix(e2e): align runners lifecycle owner#217
rowan-stein merged 6 commits into
mainfrom
noa/fix-go-core-runners-llm-helpers

Conversation

@casey-brooks

Copy link
Copy Markdown
Contributor

Summary

Context

This is needed for agynio/runners#70 and architecture #161 dependency validation after removing the legacy agent-class TouchWorkload fallback.

Validation

  • PATH=/root/.nix-profile/bin:/root/go/bin:$PATH buf generate - passed
  • CGO_ENABLED=0 PATH=/root/.nix-profile/bin:/root/go/bin:$PATH go test -tags 'e2e svc_runners' ./tests/... - compile passed; runtime failed locally because no local runners service was available (dial runners:50051: context deadline exceeded)

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the owner-alignment fix. TestRunnerLifecycle is now using the canonical owner fields, but the direct runners sampled-at helpers still create agent-instance workloads and volumes without owner_kind / owner_id, causing those E2E paths to validate legacy thread-owned compatibility instead of the runners#70 owner model.

Requesting changes to align those helpers as well.

Comment thread suites/go-core/tests/runners_test.go
@casey-brooks

Copy link
Copy Markdown
Contributor Author

Updated for Noa's requested sampled-at helper alignment.

Summary:

  • TestRunnerLifecycle was already aligned in the prior commit.
  • createRunnerWorkload now sets owner_kind=agent_instance and owner_id=<agent identity>.
  • createRunnerVolume now sets owner_kind=agent_instance and owner_id=<agent identity>.

Changed files:

  • suites/go-core/tests/runners_test.go
  • suites/go-core/tests/runners_sampled_at_test.go

Validation:

  • PATH=/root/.nix-profile/bin:/root/go/bin:$PATH buf generate - passed
  • CGO_ENABLED=0 PATH=/root/.nix-profile/bin:/root/go/bin:$PATH go test -tags 'e2e svc_runners' ./tests/... - compile passed; runtime cannot complete locally without the runners service (dial runners:50051: context deadline exceeded)
  • git diff --check - passed

@casey-brooks

Copy link
Copy Markdown
Contributor Author

Addressed Noa's sampled-at/direct runners helper comment in commit 850b40d.

Changed files:

  • suites/go-core/tests/runners_sampled_at_test.go

Both helpers now set canonical owner fields:

  • createRunnerWorkload: OwnerKind: runnersv1.RuntimeOwnerKind_RUNTIME_OWNER_KIND_AGENT_INSTANCE, OwnerId: agentID
  • createRunnerVolume: OwnerKind: runnersv1.RuntimeOwnerKind_RUNTIME_OWNER_KIND_AGENT_INSTANCE, OwnerId: agentID

Validation:

  • git diff --check passed
  • CGO_ENABLED=0 PATH=/root/.nix-profile/bin:/root/go/bin:$PATH go test -tags 'e2e svc_runners' ./tests/... -run '^$' passed: 1 package ok with no tests to run, 1 package with no test files
  • PR E2E on current head 850b40d passed

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review complete for latest head 69a09a630e29650ddbfa4811b68658e1810bd861.

I verified the prior blocker is addressed: the sampled-at workload and volume helpers now set OwnerKind: RUNTIME_OWNER_KIND_AGENT_INSTANCE and OwnerId: agentID, matching the lifecycle test and the runners#70 owner model. The PR checks are green.

Approving from code review.

@rowan-stein
rowan-stein merged commit 5d1ddd4 into main Jul 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants