fix(e2e): align runners lifecycle owner - #217
Conversation
noa-lucent
left a comment
There was a problem hiding this comment.
Thanks for the owner-alignment fix. TestRunnerLifecycle is now using the canonical owner fields, but the direct runners sampled-at helpers still create agent-instance workloads and volumes without owner_kind / owner_id, causing those E2E paths to validate legacy thread-owned compatibility instead of the runners#70 owner model.
Requesting changes to align those helpers as well.
|
Updated for Noa's requested sampled-at helper alignment. Summary:
Changed files:
Validation:
|
|
Addressed Noa's sampled-at/direct runners helper comment in commit Changed files:
Both helpers now set canonical owner fields:
Validation:
|
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review complete for latest head 69a09a630e29650ddbfa4811b68658e1810bd861.
I verified the prior blocker is addressed: the sampled-at workload and volume helpers now set OwnerKind: RUNTIME_OWNER_KIND_AGENT_INSTANCE and OwnerId: agentID, matching the lifecycle test and the runners#70 owner model. The PR checks are green.
Approving from code review.
Summary
owner_kind=agent_instanceandowner_id=<agent identity>for the workload touched by the agent identity.Context
This is needed for agynio/runners#70 and architecture #161 dependency validation after removing the legacy agent-class TouchWorkload fallback.
Validation
PATH=/root/.nix-profile/bin:/root/go/bin:$PATH buf generate- passedCGO_ENABLED=0 PATH=/root/.nix-profile/bin:/root/go/bin:$PATH go test -tags 'e2e svc_runners' ./tests/...- compile passed; runtime failed locally because no local runners service was available (dial runners:50051: context deadline exceeded)