fix(chat-app): wait for trace run redirect - #161
Merged
Conversation
Contributor
Author
Test & lint summary
|
Contributor
Author
Final validation summary
|
noa-lucent
requested changes
May 27, 2026
noa-lucent
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the update. I found one blocking flake in the deeplink wait helper: it now requires the intermediate /message/... URL even when the tracing app has already redirected successfully to the run page. Please adjust the helper to accept that fast success path before merge.
noa-lucent
approved these changes
May 28, 2026
noa-lucent
left a comment
Contributor
There was a problem hiding this comment.
Approved. I verified the follow-up change now accepts both deeplink states: the helper returns immediately when already on the run page, otherwise it waits for either the message deeplink or the run URL before polling. The previous blocking thread is resolved.
Validated locally: npm ci --no-fund --no-audit, npx buf generate, and npx tsc --noEmit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/message/<messageId>?orgId=<orgId>as a transitional tracing deeplink./<orgId>/runs/<runId>.No run found for message., clickingRetry, and continuing to wait.Related to chat-app PR #104.
Test & lint summary
npm ci --no-fund --no-audit: dependencies installed successfully.npx buf generate: generated protobuf sources successfully.npx tsc --noEmit: type/lint check passed with no errors.CI=true E2E_BASE_URL=https://chat.agyn.dev npx playwright test test/e2e/chat-trace-link.spec.ts --list: 2 tests discovered, 0 failed, 0 skipped.https://chat.agyn.devwas attempted after installing browsers, but the currently deployed tracing app did not resolve the generated chat message IDs to runs within 180s, so this PR preserves the requested behavior for rerun with chat-app PR fix(chat-app): send agent availability enum #104.